From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH v3 21/22] drm/tilcdc: Initialize crtc->port Date: Tue, 23 Feb 2016 17:19:47 +0200 Message-ID: <56CC7893.1050105@ti.com> References: <16a4e753f0388fb15b71f30d0754073367798d6d.1456239300.git.jsarha@ti.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2108188345==" Return-path: Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9BC626E5FB for ; Tue, 23 Feb 2016 15:19:54 +0000 (UTC) In-Reply-To: <16a4e753f0388fb15b71f30d0754073367798d6d.1456239300.git.jsarha@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jyri Sarha , dri-devel@lists.freedesktop.org Cc: laurent.pinchart@ideasonboard.com List-Id: dri-devel@lists.freedesktop.org --===============2108188345== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gExELOV1Ia8jb2V2GnqE7uBn85d5UdKMX" --gExELOV1Ia8jb2V2GnqE7uBn85d5UdKMX Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 23/02/16 17:03, Jyri Sarha wrote: > Initialize port device node pointer in the tilcdc crtc. Fixes "Falling > back to first CRTC" warning from tda998x driver. >=20 > The tda998x encoder driver calls drm_of_find_possible_crtcs() to > initialize possible_crtcs of struct drm_encoder. The crtc->port needs > to be initialized for drm_of_find_possible_crtcs() to work. >=20 > Signed-off-by: Jyri Sarha > --- > drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) >=20 > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/til= cdc/tilcdc_crtc.c > index 248e3ea..1eb4e0e 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > @@ -124,6 +124,7 @@ static void tilcdc_crtc_destroy(struct drm_crtc *cr= tc) > =20 > tilcdc_crtc_dpms(crtc, DRM_MODE_DPMS_OFF); > =20 > + of_node_put(crtc->port); > drm_crtc_cleanup(crtc); > drm_flip_work_cleanup(&tilcdc_crtc->unref_work); > =20 > @@ -749,6 +750,7 @@ irqreturn_t tilcdc_crtc_irq(struct drm_crtc *crtc) > =20 > struct drm_crtc *tilcdc_crtc_create(struct drm_device *dev) > { > + struct tilcdc_drm_private *priv =3D dev->dev_private; > struct tilcdc_crtc *tilcdc_crtc; > struct drm_crtc *crtc; > int ret; > @@ -775,6 +777,20 @@ struct drm_crtc *tilcdc_crtc_create(struct drm_dev= ice *dev) > =20 > drm_crtc_helper_add(crtc, &tilcdc_crtc_helper_funcs); > =20 > + if (priv->is_componentized) { > + struct device_node *ports =3D > + of_get_child_by_name(dev->dev->of_node, "ports"); > + > + if (ports) { > + crtc->port =3D of_get_child_by_name(ports, "port"); > + of_node_put(ports); > + } else { > + crtc->port =3D > + of_get_child_by_name(dev->dev->of_node, "port"); > + } > + WARN_ON(!crtc->port); > + } You didn't comment on why this is not an error? Why should the driver continue even if crtc->port is missing? Tomi --gExELOV1Ia8jb2V2GnqE7uBn85d5UdKMX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWzHiTAAoJEPo9qoy8lh71LMUQAKrdsHDYFpuFlXjP0BKWSEME DHEiWLsfiVSIRRvOFNjjm5ln8sQo2/IxugZPCVMcgBm4GQfMCfnBIfMIOyACxYug qXSgKR/XpEkgE96Bnfkelmm7u7Xa6pyMPIvtDqo0w7Ox62VUUcUX+XWMDHyHh9eq a3Hog0svGrpGOP51UU7kctWLviWqRuNXllNjb1QFZJedfmTqa97li/OU4W9EslVb sDrm8QVXqls7k921SxN+n6uuEcp1xtvujOn1tgX64jq2Frm/ndV3uN+hVurczjCP azGqlfFjv4jf0tiqM93gWC2qnQWVf8VfIYQkq7eQVY43/GMxvZC3oJ7/Ic60SiIv ApOQqtRzkRbwA+LYUimEQY0aNCeyKZArICjXQ1B/rQTuIrPEM+GF96D/nrMzewO6 eIX1L2NRh4tQNCRhbjF7kQigrPLlR/+h/cR9KQKofKm43A47zgGqlZOpQMiodpCD cDbhiG4nDs69nxW3VxysDFAUHBxyETXI/VOxnc//6XbRt72hKP2W2htIShNZD+8n yg2A7ve5tnugDz55EjHJCxYfIS5F9htAoc2y0VqdaC9DrR6kahBwOyWQbfU+JgQ1 tNShUDg3GU/v+ZEahr0WVcmy+CCeSk9CYthTzDEc4aZHn9V6jQPAwhi1bLlk9tfq cGEgkKvjuoZeAeZquzRt =YpgK -----END PGP SIGNATURE----- --gExELOV1Ia8jb2V2GnqE7uBn85d5UdKMX-- --===============2108188345== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============2108188345==--