From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH v3 21/22] drm/tilcdc: Initialize crtc->port Date: Tue, 23 Feb 2016 17:32:48 +0200 Message-ID: <56CC7BA0.9060507@ti.com> References: <16a4e753f0388fb15b71f30d0754073367798d6d.1456239300.git.jsarha@ti.com> <56CC7893.1050105@ti.com> <56CC7A09.40709@ti.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1540868268==" Return-path: Received: from bear.ext.ti.com (bear.ext.ti.com [192.94.94.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0A3C86E5FE for ; Tue, 23 Feb 2016 15:32:55 +0000 (UTC) In-Reply-To: <56CC7A09.40709@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jyri Sarha , dri-devel@lists.freedesktop.org Cc: laurent.pinchart@ideasonboard.com List-Id: dri-devel@lists.freedesktop.org --===============1540868268== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qDHeeliDlSwiFnQRgOQlVrv70lponRlsJ" --qDHeeliDlSwiFnQRgOQlVrv70lponRlsJ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 23/02/16 17:26, Jyri Sarha wrote: >> You didn't comment on why this is not an error? Why should the driver >> continue even if crtc->port is missing? >> >=20 > At least for the time being if the drm_of_find_possible_crtcs() fails > the tda998x driver assumes the first crtc with a warning. So for that > part everything will work just fine still. >=20 > Then it is another question how priv->is_componentized could be set and= > probing has gotten this far while there is no port node to be found. Th= e > WARN_ON() should really never happen as long as the code is the way it > currently is. Ok. But I think it's either ok to not have crtc->port, and in that case no print is needed, or it's not ok, and it's better to print an error and fail. Now it's kind of vague: the driver continues without crtc->port, but gives a scary WARN. Tomi --qDHeeliDlSwiFnQRgOQlVrv70lponRlsJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWzHugAAoJEPo9qoy8lh7125UP/R1N9Z+oqwbQHVEQsPn+Ago5 so0BX3nfXiA0m/cJNrdjc/9hUDGf/Rm94fDAhENN41HHEEabgOvjvtCrmWXk6Xmy SGpZaGcg7BC0F0BXFV6b9NiUY5kSD8EpYav3Oq6skkXNW3uMMwddQiuMiLYRqa5s UEes1rj+C8SbdQ79OgcWCAb/fZzbyH/CZ8Omv/DDlWxG8PQmLSCkrSdGtYylNORv jmo5DWp9dyR64z61cmK5a+98QBfVXMA5mlSlyWalTAWDoiabDTiHnvq2sAX2AI9r yjImHneTYXyjpm5K7dMGrJuR7QgvSInX169eAB5FGzFBDSLRD9Oci7bbpJkQ7rZ8 zjyJaghCxCrYNvoOIUEfRnVgOPo/LN5xl2Vqqk/29js7SzNlDn2ffH9n6hEDF1Fw fXtz1k/1Bb+Z1NrBd8w6DFOVhWWdCDDPb00+qeewl1qBjZ5RJoVEmk3L6oO4Or9v i4JGd1BkBH7gfGwQVjCB5bTHszMCxOWanWRfNi1n5Q2hsy4F0yyJDFNbl59j57oP ylPj0x4jURqKdT7zTPNJKHjK+tiURmEuS2xNdqRDldUTLRjgaY82eObZ3oDpJNQU Yjy/mIleEgVO6Midc00i49SbS0awdpCn50fDJToQ8ywYqU0thUez88CwdNNCRdhC bQIZykNvVoOwqR83xrig =eJaz -----END PGP SIGNATURE----- --qDHeeliDlSwiFnQRgOQlVrv70lponRlsJ-- --===============1540868268== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1540868268==--