From: Doug Goldstein <cardoe@cardoe.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>, xen-devel@lists.xen.org
Cc: Keir Fraser <keir@xen.org>, Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v2] xenoprof: drop necessary macro
Date: Tue, 23 Feb 2016 09:38:35 -0600 [thread overview]
Message-ID: <56CC7CFB.6090400@cardoe.com> (raw)
In-Reply-To: <56CC6263.1000101@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 791 bytes --]
On 2/23/16 7:45 AM, Andrew Cooper wrote:
> On 23/02/16 13:42, Andrew Cooper wrote:
>> On 23/02/16 13:12, Doug Goldstein wrote:
>>> This macro doesn't really provide a benefit. When support is added the
>>> implementer can implement this how it needs to be and not conform to the
>>> macro. Additionally this change limits the output of the warning to just
>>> once instead of nrpages worth. While editing this area I dropped
>>> trailing whitespace.
>>>
>>> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
>> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> You still need to correct the title, (although that could be done on
> commit).
>
> ~Andrew
>
I fail. Committers: Want me to resubmit or can you set it with
"unnecessary"?
--
Doug Goldstein
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-02-23 15:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 13:12 [PATCH v2] xenoprof: drop necessary macro Doug Goldstein
2016-02-23 13:42 ` Andrew Cooper
2016-02-23 13:45 ` Andrew Cooper
2016-02-23 15:38 ` Doug Goldstein [this message]
2016-02-23 16:15 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CC7CFB.6090400@cardoe.com \
--to=cardoe@cardoe.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.