From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] tracetool: Include osdep.h in generated-ust.c
Date: Tue, 23 Feb 2016 08:41:22 -0700 [thread overview]
Message-ID: <56CC7DA2.8020609@redhat.com> (raw)
In-Reply-To: <1456240661-15422-1-git-send-email-peter.maydell@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]
On 02/23/2016 08:17 AM, Peter Maydell wrote:
> When generating the trace/generated-ust.c source file, make sure
> it includes osdep.h as its first include.
>
> This fixes compilation with --enable-trace-backends=ust
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Picked up by the travis build tests.
>
> scripts/tracetool/format/ust_events_c.py | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/scripts/tracetool/format/ust_events_c.py b/scripts/tracetool/format/ust_events_c.py
> index bc97093..52100c0 100644
> --- a/scripts/tracetool/format/ust_events_c.py
> +++ b/scripts/tracetool/format/ust_events_c.py
> @@ -22,6 +22,8 @@ def generate(events, backend):
>
> out('/* This file is autogenerated by tracetool, do not edit. */',
> '',
> + '#include "qemu/osdep.h"',
> + '',
TAB-damaged. With that fixed,
Reviewed-by: Eric Blake <eblake@redhat.com>
> '#define TRACEPOINT_DEFINE',
> '#define TRACEPOINT_CREATE_PROBES',
> '',
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-02-23 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 15:17 [Qemu-devel] [PATCH] tracetool: Include osdep.h in generated-ust.c Peter Maydell
2016-02-23 15:41 ` Eric Blake [this message]
2016-02-23 16:13 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CC7DA2.8020609@redhat.com \
--to=eblake@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.