From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753496AbcBWQs1 (ORCPT ); Tue, 23 Feb 2016 11:48:27 -0500 Received: from smtp113.iad3a.emailsrvr.com ([173.203.187.113]:49082 "EHLO smtp113.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752530AbcBWQs0 (ORCPT ); Tue, 23 Feb 2016 11:48:26 -0500 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH] Staging: comedi: mite: added spaces around | and * To: Philippe Loctaux , gregkh@linuxfoundation.org References: <1456184291-30665-1-git-send-email-phil@philippeloctaux.com> Cc: hsweeten@visionengravers.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Ian Abbott Message-ID: <56CC8D57.7000004@mev.co.uk> Date: Tue, 23 Feb 2016 16:48:23 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <1456184291-30665-1-git-send-email-phil@philippeloctaux.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/02/16 23:38, Philippe Loctaux wrote: > Added spaces around | and *, fixing 2 checkpatch checks. > > Signed-off-by: Philippe Loctaux > --- > drivers/staging/comedi/drivers/mite.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) [snip] > @@ -216,7 +216,7 @@ EXPORT_SYMBOL_GPL(mite_free_ring); > struct mite_channel *mite_request_channel_in_range(struct mite_struct *mite, > struct > mite_dma_descriptor_ring > - *ring, unsigned min_channel, > + * ring, unsigned min_channel, > unsigned max_channel) Actually, that one looks like a false positive by the checkpatch tool. I'd expect no space after that '*'. checkpatch has probably got confused by the line-break before the '*'. It looks a bit ugly anyway. It would look better if there was a line-break before the function name, the same as in "drivers/staging/comedi/drivers/mite.h": struct mite_channel * mite_request_channel_in_range(struct mite_struct *mite, struct mite_dma_descriptor_ring *ring, unsigned min_channel, unsigned max_channel) -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-