From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] test/py: Add option to skip SPL signature checking
Date: Tue, 23 Feb 2016 10:17:10 -0700 [thread overview]
Message-ID: <56CC9416.9050407@wwwdotorg.org> (raw)
In-Reply-To: <146cef530f9c3db9de5d0394fe8718da2bf62d78.1456220400.git.michal.simek@xilinx.com>
On 02/23/2016 02:40 AM, Michal Simek wrote:
> Provide user option to skip SPL signature verification for cases where
> u-boot is build with SPL support but full U-Boot is also verified
> without SPL.
>
> If you want to support this feature please add env__spl_skipped = True
> to your boardenv configuration file.
>
> For example Xilinx Zynq is using this feature where the same U-Boot
> binary is checked with SPL and without SPL(with FSBL).
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> Tested-by: Stephen Warren <swarren@nvidia.com>
> Acked-by: Stephen Warren <swarren@nvidia.com>
Actually, NAK now...
> diff --git a/test/py/u_boot_console_base.py b/test/py/u_boot_console_base.py
> index d6502c6e64cb..b48d07261ff2 100644
> --- a/test/py/u_boot_console_base.py
> +++ b/test/py/u_boot_console_base.py
> @@ -307,7 +307,9 @@ class ConsoleBase(object):
> config_spl = bcfg.get('config_spl', 'n') == 'y'
> config_spl_serial_support = bcfg.get('config_spl_serial_support',
> 'n') == 'y'
> - if config_spl and config_spl_serial_support:
> + config_spl_skip = self.config.env.get('env_spl_skipped',
> + False)
I was talking about renaming the Python variable config_spl_skip, not
the boardenv_*.py variable env__spl_skipped.
The boardenv_*.py variable should be env__* to match existing variables
in the Python file.
I was requesting that the Python variable be named env_... not
config_... since it contains "board environment" not "config" data.
(BTW, you probably want to Cc Tom Rini on the next patch version since I
assume he'd apply this)
next prev parent reply other threads:[~2016-02-23 17:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 9:40 [U-Boot] [PATCH v2] test/py: Add option to skip SPL signature checking Michal Simek
2016-02-23 17:17 ` Stephen Warren [this message]
2016-02-25 13:59 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CC9416.9050407@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.