From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from email.microchip.com (exsmtp03.microchip.com. [198.175.253.49]) by gmr-mx.google.com with ESMTPS id 12si3949317pfb.1.2016.02.23.09.35.38 for (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 23 Feb 2016 09:35:38 -0800 (PST) Subject: [rtc-linux] Re: [PATCH v2 2/2] rtc: rtc-pic32: Add PIC32 real time clock driver To: Alexandre Belloni References: <1455905390-3491-2-git-send-email-joshua.henderson@microchip.com> <20160219181712.GD2222@piout.net> CC: , , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Alessandro Zummo , From: Joshua Henderson Message-ID: <56CC9894.7000307@microchip.com> Date: Tue, 23 Feb 2016 10:36:20 -0700 MIME-Version: 1.0 In-Reply-To: <20160219181712.GD2222@piout.net> Content-Type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Alexandre, On 02/19/2016 11:17 AM, Alexandre Belloni wrote: > Hi, > > On 19/02/2016 at 11:09:45 -0700, Joshua Henderson wrote : >> This driver adds support for the PIC32 real time clock and calendar >> peripheral: >> - reading and setting time >> - alarms when connected to an IRQ > > Just for confirmation, your probe() fails hard when there are no IRQ > specified or the IRQ request fails. > > I'll review later but if that the only thing, I can fix it up when > applying, no need to resend. > probe() does indeed fail when no interrupt is specified: ... pic32-rtc 1f8c0000.rtc: no irq for alarm ... hctosys: unable to open rtc device (rtc0) ... If I'm following, I think there right answer here is to just change the wording in the commit message to be clear that the interrupt is not conditional. It's required via binding. This peripheral has a dedicated interrupt and I can't imagine a case where it makes sense not to specify it. I'm fine with something like "- alarms provided by dedicated interrupt" as a replacement. Josh -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joshua Henderson Subject: Re: [PATCH v2 2/2] rtc: rtc-pic32: Add PIC32 real time clock driver Date: Tue, 23 Feb 2016 10:36:20 -0700 Message-ID: <56CC9894.7000307@microchip.com> References: <1455905390-3491-2-git-send-email-joshua.henderson@microchip.com> <20160219181712.GD2222@piout.net> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160219181712.GD2222-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alexandre Belloni Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Alessandro Zummo , rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org Alexandre, On 02/19/2016 11:17 AM, Alexandre Belloni wrote: > Hi, > > On 19/02/2016 at 11:09:45 -0700, Joshua Henderson wrote : >> This driver adds support for the PIC32 real time clock and calendar >> peripheral: >> - reading and setting time >> - alarms when connected to an IRQ > > Just for confirmation, your probe() fails hard when there are no IRQ > specified or the IRQ request fails. > > I'll review later but if that the only thing, I can fix it up when > applying, no need to resend. > probe() does indeed fail when no interrupt is specified: ... pic32-rtc 1f8c0000.rtc: no irq for alarm ... hctosys: unable to open rtc device (rtc0) ... If I'm following, I think there right answer here is to just change the wording in the commit message to be clear that the interrupt is not conditional. It's required via binding. This peripheral has a dedicated interrupt and I can't imagine a case where it makes sense not to specify it. I'm fine with something like "- alarms provided by dedicated interrupt" as a replacement. Josh -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754665AbcBWRfj (ORCPT ); Tue, 23 Feb 2016 12:35:39 -0500 Received: from exsmtp03.microchip.com ([198.175.253.49]:12735 "EHLO email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754052AbcBWRfi (ORCPT ); Tue, 23 Feb 2016 12:35:38 -0500 Subject: Re: [PATCH v2 2/2] rtc: rtc-pic32: Add PIC32 real time clock driver To: Alexandre Belloni References: <1455905390-3491-2-git-send-email-joshua.henderson@microchip.com> <20160219181712.GD2222@piout.net> CC: , , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Alessandro Zummo , From: Joshua Henderson Message-ID: <56CC9894.7000307@microchip.com> Date: Tue, 23 Feb 2016 10:36:20 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160219181712.GD2222@piout.net> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alexandre, On 02/19/2016 11:17 AM, Alexandre Belloni wrote: > Hi, > > On 19/02/2016 at 11:09:45 -0700, Joshua Henderson wrote : >> This driver adds support for the PIC32 real time clock and calendar >> peripheral: >> - reading and setting time >> - alarms when connected to an IRQ > > Just for confirmation, your probe() fails hard when there are no IRQ > specified or the IRQ request fails. > > I'll review later but if that the only thing, I can fix it up when > applying, no need to resend. > probe() does indeed fail when no interrupt is specified: ... pic32-rtc 1f8c0000.rtc: no irq for alarm ... hctosys: unable to open rtc device (rtc0) ... If I'm following, I think there right answer here is to just change the wording in the commit message to be clear that the interrupt is not conditional. It's required via binding. This peripheral has a dedicated interrupt and I can't imagine a case where it makes sense not to specify it. I'm fine with something like "- alarms provided by dedicated interrupt" as a replacement. Josh