From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xen.org>
Cc: Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH v3] xen: Work around Clang generating .data.rel.ro section for init-only files
Date: Tue, 23 Feb 2016 18:37:25 +0000 [thread overview]
Message-ID: <56CCA6E5.1080107@citrix.com> (raw)
In-Reply-To: <1456252563-11079-1-git-send-email-andrew.cooper3@citrix.com>
On 23/02/16 18:36, Andrew Cooper wrote:
> Clang-3.8 generates several .data.rel.ro sections when compiling Xen. As
> these contain no global symbols, they should be .data.rel.ro.local. This
> breaks the SPECIAL_DATA_SECTIONS check when converting the transition units to
> being init-only.
>
> For alternatives.c, explicitly move the nops arrays into __initconst. For efi
> boot.c, manually create the optimisation performed by Clang by collapsing the
> switch statement into a lookup table. The double use of const is required to
> avoid breaking the ARM build by creating a section type conflict with
> fdt_guid.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
>
Would you mind testing this on whichever older compiler suffered the
original symptoms? I can't find such a compiler to test with.
~Andrew
next prev parent reply other threads:[~2016-02-23 18:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 16:57 [PATCH] xen: Work around Clang generating .data.rel.ro section for init-only files Andrew Cooper
2016-02-23 9:47 ` Jan Beulich
2016-02-23 10:10 ` Andrew Cooper
2016-02-23 10:32 ` Jan Beulich
2016-02-23 18:36 ` [PATCH v3] " Andrew Cooper
2016-02-23 18:37 ` Andrew Cooper [this message]
2016-02-24 9:32 ` Jan Beulich
2016-02-24 9:49 ` Jan Beulich
2016-02-24 10:23 ` Andrew Cooper
2016-02-24 13:10 ` Jan Beulich
2016-02-24 14:59 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CCA6E5.1080107@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.