From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYJ1e-0004TP-VQ for qemu-devel@nongnu.org; Tue, 23 Feb 2016 14:53:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYJ1a-0006LP-Rf for qemu-devel@nongnu.org; Tue, 23 Feb 2016 14:53:38 -0500 Received: from mail-qg0-x236.google.com ([2607:f8b0:400d:c04::236]:33976) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYJ1a-0006Kf-Lq for qemu-devel@nongnu.org; Tue, 23 Feb 2016 14:53:34 -0500 Received: by mail-qg0-x236.google.com with SMTP id b67so145478883qgb.1 for ; Tue, 23 Feb 2016 11:53:34 -0800 (PST) Sender: Richard Henderson References: <1455889426-1923-1-git-send-email-kbastian@mail.uni-paderborn.de> From: Richard Henderson Message-ID: <56CCB8BA.60004@twiddle.net> Date: Tue, 23 Feb 2016 11:53:30 -0800 MIME-Version: 1.0 In-Reply-To: <1455889426-1923-1-git-send-email-kbastian@mail.uni-paderborn.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/4] TriCore exception patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bastian Koppelmann , qemu-devel@nongnu.org On 02/19/2016 05:43 AM, Bastian Koppelmann wrote: > v2 -> v3: > - raise_exception_sync_internal now directly modifies PC without > using the do_interrupt hook > - remove do_interrupt hook > - add fcd_pc to raise_exception_sync_internal to be used by > FCD traps > - add raise_exception_sync_helper wrapper to be used by > helper function that generate traps such that > raise_exception_sync_internal is only directly called for FCD traps > - add the generation of SOVF/OVF traps such that generate_trap() > is used to avoid a unused function compiler warning. > > v1 -> v2: > - replace helper raise_exception_error by raise_exception_sync, > that takes care of saving the pre-interrupt state for synchronous > exceptions. > - rewrite of generate_trap() in translate.c. It directly > calls the raise_exception_sync helper instead of saving the > pre-interrupt state itself. > - drop PATCH[2/5]: target-tricore: Save the pc before CSA operations for exceptions > > > Bastian Koppelmann (4): > target-tricore: Add trap handling & SOVF/OVF traps > target-tricore: add context managment trap generation > target-tricore: add illegal opcode trap generation > target-tricore: add opd trap generation > > target-tricore/cpu.h | 1 + > target-tricore/helper.h | 3 + > target-tricore/op_helper.c | 155 ++++++++++++++- > target-tricore/translate.c | 483 ++++++++++++++++++++++++++++++++++++++++++--- > 4 files changed, 610 insertions(+), 32 deletions(-) Looks good. Reviewed-by: Richard Henderson r~