From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37312) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYOu2-0007Fe-DB for qemu-devel@nongnu.org; Tue, 23 Feb 2016 21:10:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYOtz-0006Tv-7Z for qemu-devel@nongnu.org; Tue, 23 Feb 2016 21:10:10 -0500 Received: from [59.151.112.132] (port=49793 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYOty-0006Rn-PR for qemu-devel@nongnu.org; Tue, 23 Feb 2016 21:10:07 -0500 References: <1456210271-8119-1-git-send-email-caoj.fnst@cn.fujitsu.com> <20160223211614.GE3901@thinpad.lan.raisama.net> From: Cao jin Message-ID: <56CD1130.50301@cn.fujitsu.com> Date: Wed, 24 Feb 2016 10:10:56 +0800 MIME-Version: 1.0 In-Reply-To: <20160223211614.GE3901@thinpad.lan.raisama.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] topology.h: cleanup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, mst@redhat.com On 02/24/2016 05:16 AM, Eduardo Habkost wrote: > On Tue, Feb 23, 2016 at 02:51:11PM +0800, Cao jin wrote: >> remove useless parameter of several functions >> >> Signed-off-by: Cao jin > > I believe this makes the API much easier to be misused. Currently > you can safely use (smp_cores, smp_threads) every time. With this > patch, you need to always check the function definition to find > out what's the correct argument. > Yes, you do have a point here, and very interesting to me. A caller need to know/check how to use a api if it want to use it, seems a nature thing to me. Thanks for your explanation. -- Yours Sincerely, Cao jin