From mboxrd@z Thu Jan  1 00:00:00 1970
From: Doug Goldstein <cardoe@cardoe.com>
Subject: Re: [PATCH v13 1/2] vmx: VT-d posted-interrupt core
 logic handling
Date: Tue, 23 Feb 2016 21:01:45 -0600
Message-ID: <56CD1D19.1020505@cardoe.com>
References: <1456216452-3745-1-git-send-email-feng.wu@intel.com>
	<1456216452-3745-2-git-send-email-feng.wu@intel.com>
	<56CC980E02000078000D551B@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6018338909930029057=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <56CC980E02000078000D551B@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, Feng Wu <feng.wu@intel.com>
Cc: Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>, George Dunlap <george.dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Dario Faggioli <dario.faggioli@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--===============6018338909930029057==
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature";
 boundary="2G6nxgoOGpLR8X1ech2vkoRLUklk76xuP"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--2G6nxgoOGpLR8X1ech2vkoRLUklk76xuP
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

On 2/23/16 10:34 AM, Jan Beulich wrote:
>>>> On 23.02.16 at 09:34, <feng.wu@intel.com> wrote:
>=20
>> --- a/xen/include/asm-x86/hvm/hvm.h
>> +++ b/xen/include/asm-x86/hvm/hvm.h
>> @@ -565,6 +565,12 @@ const char *hvm_efer_valid(const struct vcpu *v, =

>> uint64_t value,
>>                             signed int cr0_pg);
>>  unsigned long hvm_cr4_guest_reserved_bits(const struct vcpu *v, bool_=
t=20
>> restore);
>> =20
>> +#define arch_vcpu_block(v) ({                                        =
          \
>> +    void (*func) (struct vcpu *) =3D (v)->domain->arch.hvm_domain.vmx=
=2Evcpu_block;\
>> +    if ( func )                                                      =
          \
>> +        func(v);                                                     =
          \
>> +})
>=20
> See my comment on v12. The code structure actually was better
> there, and all you needed to do is introduce a local variable.

Wouldn't this be a bit cleaner (and type-safier (inventing a word here))
to do with a static inline function?

--=20
Doug Goldstein


--2G6nxgoOGpLR8X1ech2vkoRLUklk76xuP
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0

iQJ8BAEBCgBmBQJWzR0ZXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB
MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUy44P/054aFERccexgMSHJwy+R3+i
jQdfKgfFXNYn2M7nb0Yl/gqXpaTpKMYs6aF8IUtES2hikgK49pJ/UJxcyLuIMayA
Qazh6SnfH8RakJh1FHGNfjO0XzIuTI+dUM2BbHtE7FZ9OqopM+L0IzjLzJNRgrhS
BENqpvCyY0eN3ftUg8k+haWk330KEAoUjEx1760BfIV4mgH/KQjwWf8oStG0+kr3
FUkZslCIx/tj6TkaPDjTuiy3Ak1jXixbNbs7ObeCTcItA/uP/iVAH++6Dm16h1Q1
S2QG4QOFRaFaxhzwzOxx5+ZmQ8V7pOk1bA7rHj6loxvcMD8VJTFJ+ZnPAMB1ap/U
fyko/V3mKev8QP48BXwkQuBZ1omPIVjEOxOAoZx9+XmblvDlpyRlNBDYog2rBimQ
bzAA7UQQZJ5lSy2nDuhdGn3LbfmzCk5qOvhA72bgfsF/ekCGPDIpd9lT19pFDEYh
HuWgyavt6juAKOjX4fk/664bqP/MM6AaoGgeIwd1g7/uYCimDBW0xyn3V3eO5N6D
K2YrhNfuoTaulOLb8/+n4MrTfjzJCMLCOdajRSz8C/4t/RRcAnu2yuYcsnjuQdAE
t7srhmYM923wtZdT5Fa14TVP7ovnZQZ4NhJqjUo8DnOQck50CWgaHNmnSdxGtTdW
TUmvc9xx9DOx14LxqUq6
=T4Cp
-----END PGP SIGNATURE-----

--2G6nxgoOGpLR8X1ech2vkoRLUklk76xuP--


--===============6018338909930029057==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============6018338909930029057==--