From: Hans Verkuil <hverkuil@xs4all.nl>
To: Simon Horman <horms@verge.net.au>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Magnus Damm <magnus.damm@gmail.com>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] v4l2: remove MIPI CSI-2 driver for SH-Mobile platforms
Date: Wed, 24 Feb 2016 08:20:35 +0100 [thread overview]
Message-ID: <56CD59C3.2030401@xs4all.nl> (raw)
In-Reply-To: <20160224061721.GK5435@verge.net.au>
On 02/24/2016 07:17 AM, Simon Horman wrote:
> On Wed, Feb 24, 2016 at 07:59:57AM +0200, Laurent Pinchart wrote:
>> Hi Simon,
>>
>> Thank you for the patch.
>>
>> On Wednesday 24 February 2016 11:07:59 Simon Horman wrote:
>>> This driver does not appear to have ever been used by any SoC's defconfig
>>> and does not appear to support DT. In sort it seems unused an unlikely
>>> to be used.
>>>
>>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>>> ---
>>> drivers/media/platform/soc_camera/Kconfig | 7 -
>>> drivers/media/platform/soc_camera/Makefile | 1 -
>>> drivers/media/platform/soc_camera/sh_mobile_csi2.c | 400 ------------------
>>
>> Shouldn't you also remove include/media/drv-intf/sh_mobile_csi2.h ? You would
>> then need to update drivers/media/platform/soc_camera/sh_mobile_ceu.c
>> accordingly, or remove it altogether.
>
> Thanks.
>
> sh_mobile_ceu appears to be used by several SH boards so I'd rather
> not remove it, at least not for this reason.
>
> So I'd prefer to look into updating sh_mobile_ceu.c and removing
> sh_mobile_csi2.h.
Last time I checked the ceu driver failed to work (missing clock). I'll test
again this weekend with the latest kernel. See what the status is of this driver.
I got some patches as well for the ceu, but I'm not sure if I ever got it to
fully work. I'll report back after my tests.
Regards,
Hans
>
>>> 3 files changed, 408 deletions(-)
>>> delete mode 100644 drivers/media/platform/soc_camera/sh_mobile_csi2.c
>>>
>>> Based on the master branch of media_tree
>>
>> --
>> Regards,
>>
>> Laurent Pinchart
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2016-02-24 7:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 2:07 [PATCH] v4l2: remove MIPI CSI-2 driver for SH-Mobile platforms Simon Horman
2016-02-24 5:59 ` Laurent Pinchart
2016-02-24 6:17 ` Simon Horman
2016-02-24 7:20 ` Hans Verkuil [this message]
2016-02-24 8:39 ` Geert Uytterhoeven
2016-02-24 8:46 ` Hans Verkuil
2016-02-27 17:17 ` Hans Verkuil
2016-02-24 7:22 ` Hans Verkuil
2016-02-27 17:34 ` Hans Verkuil
2016-02-24 7:51 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CD59C3.2030401@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=g.liakhovetski@gmx.de \
--cc=horms@verge.net.au \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.