From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 17/33] drm/omap: remove support for ext mem & sync Date: Wed, 24 Feb 2016 11:38:57 +0200 Message-ID: <56CD7A31.6040002@ti.com> References: <1455875288-4370-1-git-send-email-tomi.valkeinen@ti.com> <1455875288-4370-18-git-send-email-tomi.valkeinen@ti.com> <8183579.U7ycMG47Y1@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0988914621==" Return-path: Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [192.94.94.40]) by gabe.freedesktop.org (Postfix) with ESMTPS id A755C6E419 for ; Wed, 24 Feb 2016 13:58:14 +0000 (UTC) In-Reply-To: <8183579.U7ycMG47Y1@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0988914621== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TnLRW9fdrMBq4vl4Gfwwg4rA4gxI5WdFq" --TnLRW9fdrMBq4vl4Gfwwg4rA4gxI5WdFq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 24/02/16 00:42, Laurent Pinchart wrote: >> -void omap_gem_op_update(void) >=20 > The function is still referenced from a comment above omap_gem_op_async= (). Right. I changed the comment to refer to omap_gem_op_finish(). >> -int omap_gem_set_sync_object(struct drm_gem_object *obj, void *syncob= j) >=20 > And this one from a comment in the omap_gem_object() structure. Yep. I think almost all of the comment can be just removed, as SGX no longer uses this: @@ -105,17 +105,7 @@ struct omap_gem_object { * sync-object allocated on demand (if needed) * * Per-buffer sync-object for tracking pending and completed hw/d= ma - * read and write operations. The layout in memory is dictated b= y - * the SGX firmware, which uses this information to stall the com= mand - * stream if a surface is not ready yet. - * - * Note that when buffer is used by SGX, the sync-object needs to= be - * allocated from a special heap of sync-objects. This way many = sync - * objects can be packed in a page, and not waste GPU virtual add= ress - * space. Because of this we have to have a omap_gem_set_sync_ob= ject() - * API to allow replacement of the syncobj after it has (potentia= lly) - * already been allocated. A bit ugly but I haven't thought of a= - * better alternative. + * read and write operations. */ struct { uint32_t write_pending; Tomi --TnLRW9fdrMBq4vl4Gfwwg4rA4gxI5WdFq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWzXoxAAoJEPo9qoy8lh71xmMP/0FONL8kWxCr7lllfb5CYjpT bq+I4uI3Hmc0xWj+1+RCiEnAKJuEhqSrc5gKX/+5prVyBbMRKlh1MSwD7UStsBd2 /IhpXw7GPShL/SR3nW9np45Bua7k9apT8Oatmyfk3Vm1M5l/WJ4r2epDuq/BYvz6 5uvhYXDTetM1vXaJ7uhI/NtBb9HRLcEMDoecn1yIi8uE3hffc7lLf3FtbAUk6uUO I1UQoMu1zTmskPP2nBr9ziKTiGmq5dk6prTX3o24hIMQFsCF7m1UqwXIlB7gU7l1 nIPtdQoIKdYBbdbJkEHvnN62mMlOPk7pgW+yZa8vrC6hSb3T9tk+chgTde4NoDK6 3I92hWKc6dID8eRDsePAuogmKYXOM0PU/5z4OvJeHTWpelgxDZ5AbfesGKFiK7tT BNJJiMKPIZOSuidVwubWKzOu34pecBbcCLSp5mlbHTnKSbH/SmWfjfiY+spvV4oo lYx7wVCrLDYNudTE+B0XO5njj2qU5AQnNRtFxo3GwI+ZJrZ98E24tfqNKd5rmKxs BMMs0dt0vXEHLZIR+ABeon73+/AuGdZztS60MU9GCHdAk2K4lRjWX4adYhsmDDTh pZ1pNeTfmPKT3ns7t9IgIUhM4tR95AAKuNEPiyoDPU/C0dGMHCuJEWkJrXIDDqQ2 omY+b5xOjt7YE0iYqhV2 =ClLJ -----END PGP SIGNATURE----- --TnLRW9fdrMBq4vl4Gfwwg4rA4gxI5WdFq-- --===============0988914621== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0988914621==--