From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v3] xen: Work around Clang generating .data.rel.ro section for init-only files Date: Wed, 24 Feb 2016 10:23:16 +0000 Message-ID: <56CD8494.8050708@citrix.com> References: <56CC38C802000078000D516D@prv-mh.provo.novell.com> <1456252563-11079-1-git-send-email-andrew.cooper3@citrix.com> <56CD8AB002000078000D5832@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56CD8AB002000078000D5832@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Xen-devel List-Id: xen-devel@lists.xenproject.org On 24/02/16 09:49, Jan Beulich wrote: >>>> On 23.02.16 at 19:36, wrote: >> Clang-3.8 generates several .data.rel.ro sections when compiling Xen. As >> these contain no global symbols, they should be .data.rel.ro.local. This >> breaks the SPECIAL_DATA_SECTIONS check when converting the transition units >> to >> being init-only. >> >> For alternatives.c, explicitly move the nops arrays into __initconst. For >> efi >> boot.c, manually create the optimisation performed by Clang by collapsing >> the >> switch statement into a lookup table. The double use of const is required >> to >> avoid breaking the ARM build by creating a section type conflict with >> fdt_guid. >> >> Signed-off-by: Andrew Cooper > Reviewed-by: Jan Beulich > Build-tested-by: Jan Beulich > > I've also re-worded the second paragraph to refer to the newly > introduced section, and replaced "transition" with "translation" in > the first one. I hope that's okay with you. Yes - fine by me. ~Andrew