From: "Holger Hoffstätte" <holger.hoffstaette@googlemail.com>
To: fdmanana@kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] Btrfs: fix listxattrs not listing all xattrs packed in the same item
Date: Wed, 24 Feb 2016 17:11:39 +0100 [thread overview]
Message-ID: <56CDD63B.70601@googlemail.com> (raw)
In-Reply-To: <1456329239-30802-1-git-send-email-fdmanana@kernel.org>
On 02/24/16 16:53, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> In the listxattrs handler, we were not listing all the xattrs that are
> packed in the same btree item, which happens when multiple xattrs have
> a name that when crc32c hashed produce the same checksum value.
>
> Fix this by processing them all.
(snip)
> V2: Fixed logic to jump into next item, which was detected by warnings
> from gcc 5.3.0 (reported by Holger).
Great! No more warnings and also a lot less confusing. :)
thanks!
Holger
prev parent reply other threads:[~2016-02-24 16:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 17:52 [PATCH] Btrfs: fix listxattrs not listing all xattrs packed in the same item fdmanana
2016-02-23 23:29 ` Satoru Takeuchi
2016-02-24 11:42 ` Holger Hoffstätte
2016-02-24 15:53 ` [PATCH v2] " fdmanana
2016-02-24 16:11 ` Holger Hoffstätte [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CDD63B.70601@googlemail.com \
--to=holger.hoffstaette@googlemail.com \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.