From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>,
David Vrabel <david.vrabel@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
xen-devel <xen-devel@lists.xenproject.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andy Lutomirski <luto@amacapital.net>,
Borislav Petkov <bp@alien8.de>
Subject: Re: [Xen-devel] [PATCH] xen/x86: Zero out .bss for PV guests
Date: Wed, 24 Feb 2016 11:46:54 -0500 [thread overview]
Message-ID: <56CDDE7E.7040701@oracle.com> (raw)
In-Reply-To: <CAB=NE6VVwUYdcfBQRK7bQi3KMrQEOGY=Ar3MdNXp4P7wF192RA@mail.gmail.com>
On 02/24/2016 11:22 AM, Luis R. Rodriguez wrote:
> On Wed, Feb 24, 2016 at 6:58 AM, David Vrabel <david.vrabel@citrix.com> wrote:
>> Yes. Can you respin with a commit message explaining? (Or just provide
>> the message here and I'll fix it up).
> Is there no way to re-use somehow the clear_bss() from bare metal?
xen_start_info lives in .bss and it is initialized in startup assembly code.
We could move it to .data but I'd still want to do this first thing in
startup_xen(). We may add more code there later that touches something
in .bss and with delayed section clearing we may blow away that data.
-boris
> This uses a section range:
>
> /* Don't add a printk in there. printk relies on the PDA which is not
> initialized
> yet. */
> static void __init clear_bss(void)
> {
> memset(__bss_start, 0,
> (unsigned long) __bss_stop - (unsigned long) __bss_start);
> }
>
> Perhaps the section range might be different for PV guests? Or can
> this simply not work even if one added a guest bss section size, or
> would it be too late for PV guests, ie we need to do it in asm on PV
> guests as you did? If so why.
>
> Luis
next prev parent reply other threads:[~2016-02-24 16:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 22:06 [PATCH] xen/x86: Zero out .bss for PV guests Boris Ostrovsky
2016-02-24 14:12 ` David Vrabel
2016-02-24 14:12 ` [Xen-devel] " David Vrabel
2016-02-24 14:15 ` Andrew Cooper
2016-02-24 14:15 ` [Xen-devel] " Andrew Cooper
2016-02-24 14:52 ` Boris Ostrovsky
2016-02-24 14:58 ` David Vrabel
2016-02-24 14:58 ` [Xen-devel] " David Vrabel
2016-02-24 16:22 ` Luis R. Rodriguez
2016-02-24 16:46 ` Boris Ostrovsky
2016-02-24 16:46 ` Boris Ostrovsky [this message]
2016-02-24 16:22 ` Luis R. Rodriguez
2016-02-24 14:52 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CDDE7E.7040701@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mcgrof@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.