From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] net: Move CONFIG_RTL8169 to Kconfig
Date: Wed, 24 Feb 2016 09:48:53 -0700 [thread overview]
Message-ID: <56CDDEF5.3050905@wwwdotorg.org> (raw)
In-Reply-To: <1456290557-8719-2-git-send-email-bmeng.cn@gmail.com>
On 02/23/2016 10:09 PM, Bin Meng wrote:
> Introduce CONFIG_RTL8169 in Kconfig and move over boards' defconfig
> to use that.
You didn't Cc any maintainers of these files... I only accidentally
noticed this patch.
> configs/beaver_defconfig | 1 +
> configs/cardhu_defconfig | 1 +
> configs/chromebox_panther_defconfig | 1 +
> configs/jetson-tk1_defconfig | 1 +
> configs/minnowmax_defconfig | 1 +
> configs/p2371-2180_defconfig | 1 +
> configs/trimslice_defconfig | 1 +
> drivers/net/Kconfig | 6 ++++++
> include/configs/beaver.h | 1 -
> include/configs/cardhu.h | 1 -
> include/configs/chromebox_panther.h | 1 -
> include/configs/jetson-tk1.h | 1 -
> include/configs/minnowmax.h | 1 -
> include/configs/p2371-2180.h | 1 -
> include/configs/r7780mp.h | 1 -
> include/configs/sh7785lcr.h | 1 -
> include/configs/trimslice.h | 1 -
I don't see any file in configs/ that was updated to account for the
removals from r7780mp.h and sh7785lcr.h. Is that intentional?
> diff --git a/include/configs/beaver.h b/include/configs/beaver.h
> index c672a8e..21ee954 100644
> --- a/include/configs/beaver.h
> +++ b/include/configs/beaver.h
> @@ -64,7 +64,6 @@
> #define CONFIG_CMD_PCI
>
> /* PCI networking support */
> -#define CONFIG_RTL8169
>
> /* General networking support */
> #define CONFIG_CMD_DHCP
The comment "PCI networking support" and the blank line before it should
be removed too. This comment applies to a number of the other files too.
next prev parent reply other threads:[~2016-02-24 16:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 5:09 [U-Boot] [PATCH 1/2] net: Move CONFIG_RTL8139 to Kconfig Bin Meng
2016-02-24 5:09 ` [U-Boot] [PATCH 2/2] net: Move CONFIG_RTL8169 " Bin Meng
2016-02-24 16:48 ` Stephen Warren [this message]
2016-02-25 7:26 ` Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CDDEF5.3050905@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.