From: Andrei Borzenkov <arvidjaar@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>,
Eric Snowberg <eric.snowberg@oracle.com>
Cc: "daniel.kiper@oracle.com" <daniel.kiper@oracle.com>
Subject: OBP available region patch fails with clang
Date: Wed, 24 Feb 2016 20:35:33 +0300 [thread overview]
Message-ID: <56CDE9E5.5060408@gmail.com> (raw)
kern/ieee1275/mmap.c:52:22: error: comparison of integers of different
signs: 'grub_ssize_t'
(aka 'int') and 'unsigned int' [-Werror,-Wsign-compare]
if (available_size > sizeof (available))
~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~
1 error generated.
While we can of course cast to (grub_ssize_t) sizeof (available) -
should not we check for available_size < 0 as well?
next reply other threads:[~2016-02-24 17:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 17:35 Andrei Borzenkov [this message]
2016-02-24 19:13 ` OBP available region patch fails with clang Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CDE9E5.5060408@gmail.com \
--to=arvidjaar@gmail.com \
--cc=daniel.kiper@oracle.com \
--cc=eric.snowberg@oracle.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.