All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrei Borzenkov <arvidjaar@gmail.com>
To: fu.wei@linaro.org, grub-devel@gnu.org, phcoder@gmail.com
Cc: xen-devel@lists.xensource.com, Ian.Campbell@citrix.com,
	jcm@redhat.com, julien.grall@linaro.org,
	leif.lindholm@linaro.org, linaro-uefi@lists.linaro.org
Subject: Re: [PATCH 1/3] arm64: add grub_xen_boot env to indicate that we have xen_* commands
Date: Wed, 24 Feb 2016 21:12:16 +0300	[thread overview]
Message-ID: <56CDF280.3040602@gmail.com> (raw)
In-Reply-To: <1456336901-25708-2-git-send-email-fu.wei@linaro.org>

24.02.2016 21:01, fu.wei@linaro.org пишет:
> From: Fu Wei <fu.wei@linaro.org>
> 
> Signed-off-by: Fu Wei <fu.wei@linaro.org>
> ---
>  grub-core/loader/arm64/xen_boot.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/grub-core/loader/arm64/xen_boot.c b/grub-core/loader/arm64/xen_boot.c
> index 8ae43d7..ef03111 100644
> --- a/grub-core/loader/arm64/xen_boot.c
> +++ b/grub-core/loader/arm64/xen_boot.c
> @@ -20,6 +20,7 @@
>  #include <grub/charset.h>
>  #include <grub/command.h>
>  #include <grub/err.h>
> +#include <grub/env.h>
>  #include <grub/file.h>
>  #include <grub/fdt.h>
>  #include <grub/list.h>
> @@ -490,10 +491,17 @@ GRUB_MOD_INIT (xen_boot)
>      grub_register_command ("xen_module", grub_cmd_xen_module, 0,
>  			   N_("Load a xen module."));
>    my_mod = mod;
> +
> +/* setup a env to indicate that
> + * we have xen_* commands.
> + */
> +  grub_env_set ("grub_xen_boot", "y");
> +  grub_env_export ("grub_xen_boot");
>  }

Please define feature for it, see grub-core/normal/main.c.

>  
>  GRUB_MOD_FINI (xen_boot)
>  {
>    grub_unregister_command (cmd_xen_hypervisor);
>    grub_unregister_command (cmd_xen_module);
> +  grub_env_unset ("grub_xen_boot");
>  }
> 



WARNING: multiple messages have this Message-ID (diff)
From: Andrei Borzenkov <arvidjaar@gmail.com>
To: fu.wei@linaro.org, grub-devel@gnu.org, phcoder@gmail.com
Cc: xen-devel@lists.xensource.com, Ian.Campbell@citrix.com,
	jcm@redhat.com, julien.grall@linaro.org,
	leif.lindholm@linaro.org, linaro-uefi@lists.linaro.org
Subject: Re: [PATCH 1/3] arm64: add grub_xen_boot env to indicate that we have xen_* commands
Date: Wed, 24 Feb 2016 21:12:16 +0300	[thread overview]
Message-ID: <56CDF280.3040602@gmail.com> (raw)
In-Reply-To: <1456336901-25708-2-git-send-email-fu.wei@linaro.org>

24.02.2016 21:01, fu.wei@linaro.org пишет:
> From: Fu Wei <fu.wei@linaro.org>
> 
> Signed-off-by: Fu Wei <fu.wei@linaro.org>
> ---
>  grub-core/loader/arm64/xen_boot.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/grub-core/loader/arm64/xen_boot.c b/grub-core/loader/arm64/xen_boot.c
> index 8ae43d7..ef03111 100644
> --- a/grub-core/loader/arm64/xen_boot.c
> +++ b/grub-core/loader/arm64/xen_boot.c
> @@ -20,6 +20,7 @@
>  #include <grub/charset.h>
>  #include <grub/command.h>
>  #include <grub/err.h>
> +#include <grub/env.h>
>  #include <grub/file.h>
>  #include <grub/fdt.h>
>  #include <grub/list.h>
> @@ -490,10 +491,17 @@ GRUB_MOD_INIT (xen_boot)
>      grub_register_command ("xen_module", grub_cmd_xen_module, 0,
>  			   N_("Load a xen module."));
>    my_mod = mod;
> +
> +/* setup a env to indicate that
> + * we have xen_* commands.
> + */
> +  grub_env_set ("grub_xen_boot", "y");
> +  grub_env_export ("grub_xen_boot");
>  }

Please define feature for it, see grub-core/normal/main.c.

>  
>  GRUB_MOD_FINI (xen_boot)
>  {
>    grub_unregister_command (cmd_xen_hypervisor);
>    grub_unregister_command (cmd_xen_module);
> +  grub_env_unset ("grub_xen_boot");
>  }
> 


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

  reply	other threads:[~2016-02-24 18:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-24 18:01 [PATCH 0/3] arm64,xen: add xen_boot support into grup-mkconfig fu.wei
2016-02-24 18:01 ` [PATCH 1/3] arm64: add grub_xen_boot env to indicate that we have xen_* commands fu.wei
2016-02-24 18:12   ` Andrei Borzenkov [this message]
2016-02-24 18:12     ` Andrei Borzenkov
2016-02-25  6:55     ` Fu Wei
2016-02-25  6:55       ` Fu Wei
2016-02-24 18:01 ` [PATCH 2/3] * util/grub.d/20_linux_xen.in: Add support of the xen_boot command fu.wei
2016-02-24 18:09   ` Andrei Borzenkov
2016-02-24 18:09     ` Andrei Borzenkov
2016-02-24 18:01 ` [PATCH 3/3] i386, xen: Add xen_hypervisor and xen_module aliases for i386 fu.wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CDF280.3040602@gmail.com \
    --to=arvidjaar@gmail.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=fu.wei@linaro.org \
    --cc=grub-devel@gnu.org \
    --cc=jcm@redhat.com \
    --cc=julien.grall@linaro.org \
    --cc=leif.lindholm@linaro.org \
    --cc=linaro-uefi@lists.linaro.org \
    --cc=phcoder@gmail.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.