From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] package/mono: Fixing wrong MonoPosixHelper location
Date: Wed, 24 Feb 2016 21:34:43 +0100 [thread overview]
Message-ID: <56CE13E3.8050603@mind.be> (raw)
In-Reply-To: <CA+TH9VnvmxhZtx9aM0C0CCXo4duH-Y9kQ6yM5Tpia1YWpY8D4g@mail.gmail.com>
On 02/23/16 23:29, Angelo Compagnucci wrote:
> Dear Arnout Vandecappelle,
>
> 2016-02-23 23:19 GMT+01:00 Arnout Vandecappelle <arnout@mind.be>:
>> On 02/23/16 22:50, Angelo Compagnucci wrote:
>>> * This patch solves installation problems with monoposixhelper
>>
>> This description should be better, e.g. taking part of the bug description.
>>
>> libMonoPosixHelper.so will be searched in the HOST_DIR/usr/lib/ path. This path
>> and file may exist on my building machine, but not on the target.
>>
>> Fixes bug #8651.
>
> Have I to resend?
Depends on the outcome of the discussion below.
[snip]
>>
>> So 6b5f6dd0434b66062110cf764688975ecfed646f doesn't fix it? That would mean
>> that mono_assembly_getrootdir() is wrong, which is bound to lead to other
>> problems...
>
> That commit is not included in mono-4.2.2.30, could you explain better?
That commit is from the 4.3 branch (I think, I haven't made a full clone, just
browsed on github).
> Do you think I have to backport that patch from master? Honestly, if
> the released a buggy version, we should wait a correct one. I'm
> reactive about upgrading mono version in buildroot!
That commit is dated July 23, 2015, so we can wait a long time still :-)
But I asked the question because your original patch v1 was made on top of the
4.3 (or rather, master) branch. So there are two possibilities: either it's
still broken on master, or you never actually tested the master branch before
you submitted the patch upstream.
- If it is not broken on master, then it's better to backport commit
6b5f6dd0434b66062110cf764688975ecfed646f from master.
- If it is still broken on master, then your patch is good for buildroot, but I
fear there will be other issues lurking in the shadows because it means the
mono_assembly_getrootdir() function doesn't work correctly in buildroot.
Regards,
Arnout
[snip]
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
next prev parent reply other threads:[~2016-02-24 20:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 21:50 [Buildroot] [PATCH v3] package/mono: Fixing wrong MonoPosixHelper location Angelo Compagnucci
2016-02-23 22:19 ` Arnout Vandecappelle
2016-02-23 22:29 ` Angelo Compagnucci
2016-02-24 20:34 ` Arnout Vandecappelle [this message]
2016-02-24 20:46 ` Angelo Compagnucci
2016-02-24 23:09 ` Arnout Vandecappelle
2016-02-25 7:42 ` Angelo Compagnucci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CE13E3.8050603@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.