All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Skeggs <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Karol Herbst <nouveau-lIBOoy2+GI7scQ4cX5LuPg@public.gmane.org>,
	nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH v5 0/6] Suppor for various power sensors on GF100+
Date: Thu, 25 Feb 2016 08:22:49 +1000	[thread overview]
Message-ID: <56CE2D39.3090509@redhat.com> (raw)
In-Reply-To: <1456344481-934-1-git-send-email-nouveau-lIBOoy2+GI7scQ4cX5LuPg@public.gmane.org>


[-- Attachment #1.1: Type: text/plain, Size: 3107 bytes --]

On 02/25/2016 06:07 AM, Karol Herbst wrote:
> This is a complete rework from the first version I sent out.
> 
> Now the implementation is more centered around the power_rails we find in the
> SENSE table instead of extdev centered. This makes the implementation a lot
> easier and straightforward.
> 
> I've added support for the INA219, INA209 and INA3221 sensors found on multiple
> Fermi and Kepler cards.
> 
> The power consumption is also exported via hwmon, so "sensors" will be able to
> print it in userspace.
> 
> This work is based on Martins initial power sensor work and most of the ground
> work was just copied from him.
Looks OK to me, but needs a rebase on top of my tree (will conflict with
secure boot patches I just merged) before merging.

Thanks,
Ben.

> 
> Happy testing
> 
> changes in v3: fixes ina2x9, rebase on current master
> changes in v4: some minor ina2x9 fixes and get it to work on maxwell gen2
> changes in v5: final polishing
> 
> Tested-by: Stefan Hühner <stefan-Xd65/bSt805AfugRpC6u6w@public.gmane.org> on gm206
> 
> Karol Herbst (4):
>   iccsense: implement for ina209, ina219 and ina3221
>   hwmon: add power consumption
>   hwmon: don't require therm to be valid to get any data
>   bios/extdev: also parse v4.1 table
> 
> Martin Peres (2):
>   subdev/iccsense: add new subdev for power sensors
>   nvbios/iccsense: add parsing of the SENSE table
> 
>  drm/nouveau/include/nvif/device.h               |   1 +
>  drm/nouveau/include/nvkm/core/device.h          |  83 +++++----
>  drm/nouveau/include/nvkm/subdev/bios/extdev.h   |   3 +
>  drm/nouveau/include/nvkm/subdev/bios/iccsense.h |  16 ++
>  drm/nouveau/include/nvkm/subdev/i2c.h           |  31 ++++
>  drm/nouveau/include/nvkm/subdev/iccsense.h      |  17 ++
>  drm/nouveau/nouveau_hwmon.c                     |  75 ++++++--
>  drm/nouveau/nvkm/core/subdev.c                  |  83 ++++-----
>  drm/nouveau/nvkm/engine/device/base.c           | 144 ++++++++-------
>  drm/nouveau/nvkm/engine/device/priv.h           |   1 +
>  drm/nouveau/nvkm/subdev/Kbuild                  |   1 +
>  drm/nouveau/nvkm/subdev/bios/Kbuild             |   1 +
>  drm/nouveau/nvkm/subdev/bios/extdev.c           |   2 +-
>  drm/nouveau/nvkm/subdev/bios/iccsense.c         | 100 ++++++++++
>  drm/nouveau/nvkm/subdev/iccsense/Kbuild         |   2 +
>  drm/nouveau/nvkm/subdev/iccsense/base.c         | 232 ++++++++++++++++++++++++
>  drm/nouveau/nvkm/subdev/iccsense/gf100.c        |  31 ++++
>  drm/nouveau/nvkm/subdev/iccsense/priv.h         |  16 ++
>  18 files changed, 676 insertions(+), 163 deletions(-)
>  create mode 100644 drm/nouveau/include/nvkm/subdev/bios/iccsense.h
>  create mode 100644 drm/nouveau/include/nvkm/subdev/iccsense.h
>  create mode 100644 drm/nouveau/nvkm/subdev/bios/iccsense.c
>  create mode 100644 drm/nouveau/nvkm/subdev/iccsense/Kbuild
>  create mode 100644 drm/nouveau/nvkm/subdev/iccsense/base.c
>  create mode 100644 drm/nouveau/nvkm/subdev/iccsense/gf100.c
>  create mode 100644 drm/nouveau/nvkm/subdev/iccsense/priv.h
> 


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

      parent reply	other threads:[~2016-02-24 22:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-24 20:07 [PATCH v5 0/6] Suppor for various power sensors on GF100+ Karol Herbst
     [not found] ` <1456344481-934-1-git-send-email-nouveau-lIBOoy2+GI7scQ4cX5LuPg@public.gmane.org>
2016-02-24 20:07   ` [PATCH v5 1/6] subdev/iccsense: add new subdev for power sensors Karol Herbst
2016-02-24 20:07   ` [PATCH v5 2/6] nvbios/iccsense: add parsing of the SENSE table Karol Herbst
2016-02-24 20:07   ` [PATCH v5 3/6] iccsense: implement for ina209, ina219 and ina3221 Karol Herbst
2016-02-24 20:07   ` [PATCH v5 4/6] hwmon: add power consumption Karol Herbst
2016-02-24 20:08   ` [PATCH v5 5/6] hwmon: don't require therm to be valid to get any data Karol Herbst
2016-02-24 20:08   ` [PATCH v5 6/6] bios/extdev: also parse v4.1 table Karol Herbst
2016-02-24 22:22   ` Ben Skeggs [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CE2D39.3090509@redhat.com \
    --to=bskeggs-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=nouveau-lIBOoy2+GI7scQ4cX5LuPg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.