From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39206)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiecl.fnst@cn.fujitsu.com>) id 1aYkeV-0007nb-Dm
	for qemu-devel@nongnu.org; Wed, 24 Feb 2016 20:23:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xiecl.fnst@cn.fujitsu.com>) id 1aYkeQ-0006Q4-E1
	for qemu-devel@nongnu.org; Wed, 24 Feb 2016 20:23:35 -0500
Received: from [59.151.112.132] (port=1590 helo=heian.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiecl.fnst@cn.fujitsu.com>) id 1aYkeP-0006Pp-9z
	for qemu-devel@nongnu.org; Wed, 24 Feb 2016 20:23:30 -0500
Message-ID: <56CE57E6.8050605@cn.fujitsu.com>
Date: Thu, 25 Feb 2016 09:24:54 +0800
From: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
MIME-Version: 1.0
References: <1456308715-15465-1-git-send-email-xiecl.fnst@cn.fujitsu.com>
	<1456308715-15465-3-git-send-email-xiecl.fnst@cn.fujitsu.com>
	<56CDE156.3020703@redhat.com> <56CE4FC8.5060605@cn.fujitsu.com>
	<56CE54E5.8060509@redhat.com>
In-Reply-To: <56CE54E5.8060509@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 2/3] qmp event: Refactor
	QUORUM_REPORT_BAD
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, Wen Congyang <wency@cn.fujitsu.com>, qemu devel <qemu-devel@nongnu.org>, Alberto Garcia <berto@igalia.com>, Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>, Markus Armbruster <armbru@redhat.com>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

On 02/25/2016 09:12 AM, Eric Blake wrote:
> On 02/24/2016 05:50 PM, Wen Congyang wrote:
>
>>>> +- "type":          Quorum operation type (json-string, optional)
>>>
>>> I don't think 'type' needs to be optional, after all.  Just always
>>> output it.
>>
>> If we output read/write type, old libvirt will ignore the read/write error events?
>
> The QMP protocol already documents that ALL clients MUST ignore
> unexpected output fields.  Any client that is unprepared for new fields
> appearing in the dictionary is buggy.  Libvirt will be just fine if you
> output a new "type":"read".

Ok, i'll make "type" mandatory.

Thanks
	-Xie

>