From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760569AbcBYLDq (ORCPT ); Thu, 25 Feb 2016 06:03:46 -0500 Received: from arrakis.dune.hu ([78.24.191.176]:47684 "EHLO arrakis.dune.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752104AbcBYLDo (ORCPT ); Thu, 25 Feb 2016 06:03:44 -0500 Subject: Re: [PATCH V2] phy: ralink-usb: add driver for Mediatek/Ralink To: Kishon Vijay Abraham I , Rob Herring References: <1451936029-41153-1-git-send-email-blogic@openwrt.org> <56CAE795.2030401@ti.com> Cc: linux-kernel@vger.kernel.org From: John Crispin Message-ID: <56CEDF7F.60105@openwrt.org> Date: Thu, 25 Feb 2016 12:03:27 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56CAE795.2030401@ti.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/02/2016 11:48, Kishon Vijay Abraham I wrote: > Hi Rob, > > On Tuesday 05 January 2016 01:03 AM, John Crispin wrote: >> Add a driver to setup the USB phy on Mediatek/Ralink SoCs. >> The driver is trivial and only sets up power and host mode. >> >> Signed-off-by: John Crispin >> --- >> Changes in V2 >> * remove refcounting >> * drop empty functions >> * dont use static globals >> * use explicit compatible strings >> >> .../devicetree/bindings/phy/ralink-usb-phy.txt | 17 ++ >> drivers/phy/Kconfig | 8 + >> drivers/phy/Makefile | 1 + >> drivers/phy/phy-ralink-usb.c | 175 ++++++++++++++++++++ >> 4 files changed, 201 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/phy/ralink-usb-phy.txt >> create mode 100644 drivers/phy/phy-ralink-usb.c >> >> diff --git a/Documentation/devicetree/bindings/phy/ralink-usb-phy.txt b/Documentation/devicetree/bindings/phy/ralink-usb-phy.txt >> new file mode 100644 >> index 0000000..5b27cad >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/ralink-usb-phy.txt >> @@ -0,0 +1,17 @@ >> +Mediatek/Ralink USB PHY >> + >> +Required properties: >> + - compatible: ralink,rt3352-usbphy or mediatek,mt7620-usbphy >> + - #phy-cells: should be 0 >> + - resets: the two reset controllers for host and device >> + - reset-names: the names of the 2 reset controllers >> + > > Does this binding documentation look okay to you? Should the documentation come > in a separate file? > > Thanks > Kishon > let me resend the whole thing as a V3 split into 2 patches John