From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Dichtel Subject: Re: [PATCH] ipv4: in new netns initialize sysctls in net.ipv4.conf.* with defaults Date: Thu, 25 Feb 2016 15:20:48 +0100 Message-ID: <56CF0DC0.7030003@6wind.com> References: <20160221071102.9686.63148.stgit@buzz> <20160223.182121.2101846699151527296.davem@davemloft.net> <87y4a9ix2h.fsf@x220.int.ebiederm.org> Reply-To: nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <87y4a9ix2h.fsf-JOvCrm2gF+uungPnsOpG7nhyD016LWXt@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Eric W. Biederman" , David Miller Cc: khlebnikov-XoJtRXgx1JseBXzfvpsJ4g@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, vvs-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: containers.vger.kernel.org TGUgMjQvMDIvMjAxNiAyMzowNSwgRXJpYyBXLiBCaWVkZXJtYW4gYSDDqWNyaXQgOgpbc25pcF0K PiBJbiB0aGUgZ2VuZXJhbCBjYXNlIHRoZSBjdXJyZW50IGJlaGF2aW9yIGlzIHJhbmRvbSBhbmQg bm90IHNvbWV0aGluZwo+IGFwcGxpY2F0aW9ucyBjYW4gY291bnQgb24sIGFuZCB3ZSB3b3VsZCBk byB3ZWxsIHRvIGZpeCBpdCBzbyBpdCBpcyBsZXNzCj4gcmFuZG9tLiAgSW4gcGFydGljdWxhciBj b25zaWRlciB0aGUgY2FzZSBvZiBhbiBhcHBsaWNhdGlvbiBpbiBhCj4gbm9uLWluaXRpYWwgbmV0 d29yayBuYW1lc3BhY2UgY3JlYXRpbmcgYSBuZXcgbmV0d29yayBuYW1lc3BhY2UuICBJdCBpcwo+ IG5vdCBldmVuIHBvc3NpYmxlIHRvIHByZWRpY3Qgd2hhdCB2YWx1ZXMgdGhleSB3aWxsIGdldCBm b3Igc3lzY3Rscwo+IHRvZGF5LgorMQoKPiAgRnJvbSBhIGJhY2t3YXJkcyBjb21wYXRpYmlsaXR5 IHN0YW5kcG9pbnQgd2UgYXJlIHByb2JhYmx5IGJldHRlciBvZmYKPiB3aXRoIGNvcHlpbmcgZnJv bSB0aGUgY3VycmVudCBuZXR3b3JrIG5hbWVzcGFjZSByYXRoZXIgdGhhbiB0aGUgaW5pdGlhbAo+ IG5ldHdvcmsgbmFtZXNwYWNlLiAgQXMgdGhhdCBtb3JlIGNsb3NlbHkgcmVzZW1ibGVzIHRoZSBj b21tb24gY2FzZQo+IHRvZGF5LgorMQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KQ29udGFpbmVycyBtYWlsaW5nIGxpc3QKQ29udGFpbmVyc0BsaXN0cy5s aW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFp bG1hbi9saXN0aW5mby9jb250YWluZXJz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760723AbcBYOUx (ORCPT ); Thu, 25 Feb 2016 09:20:53 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:35009 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760063AbcBYOUv (ORCPT ); Thu, 25 Feb 2016 09:20:51 -0500 Reply-To: nicolas.dichtel@6wind.com Subject: Re: [PATCH] ipv4: in new netns initialize sysctls in net.ipv4.conf.* with defaults References: <20160221071102.9686.63148.stgit@buzz> <20160223.182121.2101846699151527296.davem@davemloft.net> <87y4a9ix2h.fsf@x220.int.ebiederm.org> To: "Eric W. Biederman" , David Miller Cc: khlebnikov@yandex-team.ru, netdev@vger.kernel.org, containers@lists.linux-foundation.org, vvs@virtuozzo.com, linux-kernel@vger.kernel.org From: Nicolas Dichtel Organization: 6WIND Message-ID: <56CF0DC0.7030003@6wind.com> Date: Thu, 25 Feb 2016 15:20:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <87y4a9ix2h.fsf@x220.int.ebiederm.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 24/02/2016 23:05, Eric W. Biederman a écrit : [snip] > In the general case the current behavior is random and not something > applications can count on, and we would do well to fix it so it is less > random. In particular consider the case of an application in a > non-initial network namespace creating a new network namespace. It is > not even possible to predict what values they will get for sysctls > today. +1 > From a backwards compatibility standpoint we are probably better off > with copying from the current network namespace rather than the initial > network namespace. As that more closely resembles the common case > today. +1