Re: [Qemu-devel] [PATCH 01/13] q35: add "int-remap" flag to enable intr

[Marcel Apfelbaum <marcel@redhat.com>]

On 02/23/2016 05:48 AM, Peter Xu wrote:
> On Sun, Feb 21, 2016 at 12:38:38PM +0200, Marcel Apfelbaum wrote:
>> On 02/19/2016 05:30 AM, Peter Xu wrote:
>>> One flag is added to specify whether to enable INTR for emulated
>>> IOMMU. By default, interrupt remapping is not supportted. To enable it,
>>> we should specify something like:
>>>
>>> $ qemu-system-x86_64 -M q35,iommu=on,int_remap=on
>>
>> Hi Peter,
>>
>> Please be aware that there is an AMD IOMMU emulation series on the list,
>> so now we will have iommu=intel/amd/off.
>>
>> As far as I know we prefer int-remap instead of int_remap and also
>> the "int" prefix reminds me integer, I would use ir=on or the clean interrupt-remapping=on.
>
> Hi, Marcel,
>
> Really appreciated for all of your review comments for the series!
>
> As I worked on this without noticing that Jan/Rita is working on
> this too, I may need to halt here and wait for her patches. So
> please ignore this patchset for now, and let's all wait for Rita's
> first version.
>

Hi Peter,

> Sorry for wasting your time on this!


No problem, really, it happens :)
Now you can much easier review their work and improve it as you see fit.

Good luck,
Marcel

>
> Thanks!
> Peter
>