From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYy8H-0006R2-NU for qemu-devel@nongnu.org; Thu, 25 Feb 2016 10:47:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYy8E-0002xv-26 for qemu-devel@nongnu.org; Thu, 25 Feb 2016 10:47:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56788) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYy8D-0002xp-SD for qemu-devel@nongnu.org; Thu, 25 Feb 2016 10:47:09 -0500 References: <1455852618-5224-1-git-send-email-peterx@redhat.com> <1455852618-5224-2-git-send-email-peterx@redhat.com> <56C993AE.7010703@gmail.com> <20160223034840.GB20689@pxdev.xzpeter.org> From: Marcel Apfelbaum Message-ID: <56CF21F7.9030508@redhat.com> Date: Thu, 25 Feb 2016 17:47:03 +0200 MIME-Version: 1.0 In-Reply-To: <20160223034840.GB20689@pxdev.xzpeter.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/13] q35: add "int-remap" flag to enable intr List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: ehabkost@redhat.com, mst@redhat.com, jasowang@redhat.com, qemu-devel@nongnu.org, imammedo@redhat.com, pbonzini@redhat.com, David Kiarie , rth@twiddle.net On 02/23/2016 05:48 AM, Peter Xu wrote: > On Sun, Feb 21, 2016 at 12:38:38PM +0200, Marcel Apfelbaum wrote: >> On 02/19/2016 05:30 AM, Peter Xu wrote: >>> One flag is added to specify whether to enable INTR for emulated >>> IOMMU. By default, interrupt remapping is not supportted. To enable it, >>> we should specify something like: >>> >>> $ qemu-system-x86_64 -M q35,iommu=on,int_remap=on >> >> Hi Peter, >> >> Please be aware that there is an AMD IOMMU emulation series on the list, >> so now we will have iommu=intel/amd/off. >> >> As far as I know we prefer int-remap instead of int_remap and also >> the "int" prefix reminds me integer, I would use ir=on or the clean interrupt-remapping=on. > > Hi, Marcel, > > Really appreciated for all of your review comments for the series! > > As I worked on this without noticing that Jan/Rita is working on > this too, I may need to halt here and wait for her patches. So > please ignore this patchset for now, and let's all wait for Rita's > first version. > Hi Peter, > Sorry for wasting your time on this! No problem, really, it happens :) Now you can much easier review their work and improve it as you see fit. Good luck, Marcel > > Thanks! > Peter >