From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 30/33] drm/omap: verify that fb plane pitches are the same Date: Thu, 25 Feb 2016 17:56:57 +0200 Message-ID: <56CF2449.1060908@ti.com> References: <1455875288-4370-1-git-send-email-tomi.valkeinen@ti.com> <1455875288-4370-31-git-send-email-tomi.valkeinen@ti.com> <1711537.Yp97coqSLh@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1280018334==" Return-path: Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [192.94.94.40]) by gabe.freedesktop.org (Postfix) with ESMTPS id 480336E8EC for ; Thu, 25 Feb 2016 15:57:03 +0000 (UTC) In-Reply-To: <1711537.Yp97coqSLh@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1280018334== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cHTjKuQ79l8hdR45beJdk15kfflPi67h9" --cHTjKuQ79l8hdR45beJdk15kfflPi67h9 Content-Type: multipart/mixed; boundary="g7eDQ4xmrXiUjPsMjAMPFUO7Mqr9LDJwE" From: Tomi Valkeinen To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, Rob Clark Message-ID: <56CF2449.1060908@ti.com> Subject: Re: [PATCH 30/33] drm/omap: verify that fb plane pitches are the same References: <1455875288-4370-1-git-send-email-tomi.valkeinen@ti.com> <1455875288-4370-31-git-send-email-tomi.valkeinen@ti.com> <1711537.Yp97coqSLh@avalon> In-Reply-To: <1711537.Yp97coqSLh@avalon> --g7eDQ4xmrXiUjPsMjAMPFUO7Mqr9LDJwE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 24/02/16 01:02, Laurent Pinchart wrote: > Hi Tomi, >=20 > Thank you for the patch. >=20 > On Friday 19 February 2016 11:48:05 Tomi Valkeinen wrote: >> The DSS hardware uses the same ROW_INC value for both Y and UV planes >> for NV12 format. This means that the pitches of the Y and UV planes ha= ve >> to match. omapdrm doesn't check this at the moment, and this can lead >> into a broken NV12 fb on the screen. >> >> This patch adds the check. >> >> Signed-off-by: Tomi Valkeinen >=20 > Reviewed-by: Laurent Pinchart >=20 > We can probably simplify the implementation further as most of the chec= ks in=20 > the loop apply to the first place only. Would you like me to give it a = go ? "place" is plane? I don't quite understand what you mean. The checks apply to all planes. Tomi --g7eDQ4xmrXiUjPsMjAMPFUO7Mqr9LDJwE-- --cHTjKuQ79l8hdR45beJdk15kfflPi67h9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWzyRJAAoJEPo9qoy8lh71nyMQAJ5tGPlLS0LkXRZFEe5E0QT2 rRMQNsOoymA8ZNZj2cnE43Lsy3Yn+EwBPbmm3aqvbHUkHNxvRYytkIgjy6QmTYsh 3IKOrY85xqnBVXTH8pW502rR+fCEdrhTGvYuAD7fJ7s8RvA5W7ePMxt4Jo+7y+BU n45CEJydkGOz5nLMp8OcSAhmn/cyYadDGih0bPd4YxCiFoRjmy0vh4E3NoGTKRC1 cmIJr6IreczytviVZpkko9qvVAZK8XZD9AJwij7CZiZ08NIPVXRg7AVmZB6RWx06 mBE5k26uUFIqiU9AA0p1b3JAGcy7TqdeGcS9CPZf2QAF2puh7tIEyPEWXS30fNwE 7cq8BMTYaibBtRhm/OVtllVQkqCfLh7z0zUaTR/o9S8af2QwvPBc785eeAV1WK3D CZJWy4J5SQqn+/gpiRaFkBUJhWdqJ29A76CSGDOIr+pr4U/019b2Eh0naANVvMvo 8q3E5GZCkHz05NQ1BFFUV54F7vEguV5MdhhmfXk1iOXIcbjxItUZSC3HB8pp/Zy3 AziIRV3R6Mserc7WGRPiQErGsk6VFZb3dzv6OSn8gQcukr9RKV/hltwvrUuuwRDB E4RwRBfX/ZsF7sca/wW4K+GdY3I8D+xEueyl9uR2jdC/6Ea6EUK8SYFBDehe2YC9 cHUPee3GG3t7CdQYSFpf =ZyHX -----END PGP SIGNATURE----- --cHTjKuQ79l8hdR45beJdk15kfflPi67h9-- --===============1280018334== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1280018334==--