From: Olga Pshenichnikova <olga@ip-5.ru>
To: Thomas Gummerer <t.gummerer@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Some strange behavior of git
Date: Thu, 25 Feb 2016 19:43:08 +0300 [thread overview]
Message-ID: <56CF2F1C.9070803@ip-5.ru> (raw)
In-Reply-To: <20160225161409.GK1831@hank>
Thanx )
On 02/25/2016 07:14 PM, Thomas Gummerer wrote:
> [Please keep everyone cc'd in the conversation, especially the mailing
> list. I added it back for now.
> Also please don't top post on the list]
>
> On 02/25, Olga Pshenichnikova wrote:
>> No, it isn't empty, but I found the problem.
>> Problem was that I handled subdirectories structure in exclude file:
>>
>> design/dir1
>> design/dir2
>>
>> But
>>
>> design/dir3 wasn't ignored and wasn't controlled.
>>
>> So, my problem take place when some sub directory both isn't ignored AND
>> isn't controlled even if it isn't empty.
> I think that's a bug, I think this directory should only be removed if
> -x is given. I haven't come up with a patch yet, but here's a test
> demonstrating the failure.
>
> diff --git a/t/t7300-clean.sh b/t/t7300-clean.sh
> index 86ceb38..0961007 100755
> --- a/t/t7300-clean.sh
> +++ b/t/t7300-clean.sh
> @@ -653,4 +653,13 @@ test_expect_success 'git clean -d respects pathspecs (pathspec is prefix of dir)
> test_path_is_dir foobar
> '
>
> +test_expect_failure 'git clean -d does not clean ignored files in subdir' '
> + mkdir -p sub/dir &&
> + >sub/dir/file &&
> + test_when_finished rm .gitignore &&
> + echo sub/dir/ >.gitignore &&
> + git clean -df sub &&
> + test_path_is_file sub/dir/file
> +'
> +
> test_done
>
>
>> Thank you for response!
prev parent reply other threads:[~2016-02-25 16:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 22:43 Some strange behavior of git Olga Pshenichnikova
2016-02-24 22:57 ` Stefan Beller
2016-02-24 23:10 ` Randall S. Becker
2016-02-25 9:57 ` Thomas Gummerer
[not found] ` <56CED1F8.60601@ip-5.ru>
2016-02-25 16:14 ` Thomas Gummerer
2016-02-25 16:43 ` Olga Pshenichnikova [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CF2F1C.9070803@ip-5.ru \
--to=olga@ip-5.ru \
--cc=git@vger.kernel.org \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.