All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrei Borzenkov <arvidjaar@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>,
	Juergen Gross <jgross@suse.com>
Cc: phcoder@gmail.com, mchang@suse.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v4 02/11] xen: avoid memleaks on error
Date: Thu, 25 Feb 2016 20:38:24 +0300	[thread overview]
Message-ID: <56CF3C10.40005@gmail.com> (raw)
In-Reply-To: <20160222082432.GM3482@olila.local.net-space.pl>

22.02.2016 11:24, Daniel Kiper пишет:
> 
> Are you sure that grub_errno is always set to GRUB_ERR_NONE
> if any GRUB2 function finished successfully?

grub_errno is reset by command parser before command execution (or after
previous command finished actually). During command execution there is
no guarantee that this happens; sometimes grub_errno is explicitly reset
to suppress subsequent errors but in general errors are just passed through.

> Maybe you should
> set initialize grub_errno with GRUB_ERR_NONE at the beginning
> of parse_xen_guest()?
> 
> Daniel
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
> 



  parent reply	other threads:[~2016-02-25 17:38 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-22  6:03 [PATCH v4 00/11] grub-xen: support booting huge pv-domains Juergen Gross
2016-02-22  6:03 ` [PATCH v4 01/11] xen: make xen loader callable multiple times Juergen Gross
2016-02-22  6:03 ` Juergen Gross
2016-02-22  8:09   ` Daniel Kiper
2016-02-22  8:09   ` Daniel Kiper
2016-02-22  6:03 ` [PATCH v4 02/11] xen: avoid memleaks on error Juergen Gross
2016-02-22  8:24   ` Daniel Kiper
2016-02-22  8:24   ` Daniel Kiper
2016-02-22  9:06     ` Juergen Gross
2016-02-22  9:06     ` Juergen Gross
2016-02-25 17:38     ` Andrei Borzenkov [this message]
2016-02-25 17:38     ` Andrei Borzenkov
2016-02-22  6:03 ` Juergen Gross
2016-02-22  6:03 ` [PATCH v4 03/11] xen: reduce number of global variables in xen loader Juergen Gross
2016-02-22  6:03 ` Juergen Gross
2016-02-22  6:03 ` [PATCH v4 04/11] xen: add elfnote.h to avoid using numbers instead of constants Juergen Gross
2016-02-22  6:03 ` Juergen Gross
2016-02-22  6:03 ` [PATCH v4 05/11] xen: synchronize xen header Juergen Gross
2016-02-22  6:03 ` [PATCH v4 06/11] xen: factor out p2m list allocation into separate function Juergen Gross
2016-02-22  6:03 ` Juergen Gross
2016-02-22  6:03 ` [PATCH v4 07/11] xen: factor out allocation of special pages " Juergen Gross
2016-02-22  6:03 ` Juergen Gross
2016-02-22  6:03 ` [PATCH v4 08/11] xen: factor out allocation of page tables " Juergen Gross
2016-02-22  6:03 ` [PATCH v4 09/11] xen: add capability to load initrd outside of initial mapping Juergen Gross
2016-02-22  8:42   ` Daniel Kiper
2016-02-22  9:18     ` Juergen Gross
2016-02-22 12:24       ` Daniel Kiper
2016-02-22 12:24       ` Daniel Kiper
2016-02-22 13:26         ` Juergen Gross
2016-02-22 13:26         ` Juergen Gross
2016-02-22  9:18     ` Juergen Gross
2016-02-22  8:42   ` Daniel Kiper
2016-02-22  6:03 ` Juergen Gross
2016-02-22  6:03 ` [PATCH v4 10/11] xen: modify page table construction Juergen Gross
2016-02-22  9:17   ` Daniel Kiper
2016-02-22  9:29     ` Juergen Gross
2016-02-22 12:18       ` Daniel Kiper
2016-02-22 12:18       ` Daniel Kiper
2016-02-22 12:30         ` Juergen Gross
2016-02-22 12:30         ` Juergen Gross
2016-02-22 12:48           ` Daniel Kiper
2016-02-22 12:48           ` Daniel Kiper
2016-02-22 13:14             ` Juergen Gross
2016-02-22 13:14             ` Juergen Gross
2016-02-25 18:33               ` Andrei Borzenkov
2016-02-29  9:13                 ` Juergen Gross
2016-02-29 12:19                   ` Juergen Gross
2016-03-01  3:52                     ` Andrei Borzenkov
2016-03-01  5:12                       ` [Xen-devel] " Juergen Gross
2016-03-01  5:12                       ` Juergen Gross
2016-03-01  3:52                     ` Andrei Borzenkov
2016-03-02  9:12                     ` Daniel Kiper
2016-03-02 15:43                       ` Juergen Gross
2016-03-02 15:43                       ` Juergen Gross
2016-03-02 16:04                         ` Daniel Kiper
2016-03-02 16:04                         ` Daniel Kiper
2016-03-02  9:12                     ` Daniel Kiper
2016-02-29 12:19                   ` Juergen Gross
2016-02-29  9:13                 ` Juergen Gross
2016-02-25 18:33               ` Andrei Borzenkov
2016-02-22  9:29     ` Juergen Gross
2016-02-22  9:17   ` Daniel Kiper
2016-02-22  6:03 ` [PATCH v4 11/11] xen: add capability to load p2m list outside of kernel mapping Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CF3C10.40005@gmail.com \
    --to=arvidjaar@gmail.com \
    --cc=grub-devel@gnu.org \
    --cc=jgross@suse.com \
    --cc=mchang@suse.com \
    --cc=phcoder@gmail.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.