From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] serial: Move carriage return before line feed for some serial drivers
Date: Thu, 25 Feb 2016 18:55:35 +0100 [thread overview]
Message-ID: <56CF4017.3040505@denx.de> (raw)
In-Reply-To: <1456368085-19979-1-git-send-email-b18965@freescale.com>
On 02/25/2016 03:41 AM, Alison Wang wrote:
> In general, a carriage return needs to execute before a line feed.
> The patch is to change some serial drivers based on this rule, such
> as serial_mxc.c, serial_pxa.c, serial_s3c24x0.c and usbtty.c.
>
> Signed-off-by: Alison Wang <alison.wang@nxp.com>
Why isn't this CR-LF stuff handled in common code instead ? It'd be much
better than having billion copies of the exact same logic (some of them
more buggy than the others) in drivers.
next prev parent reply other threads:[~2016-02-25 17:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 2:41 [U-Boot] [PATCH] serial: Move carriage return before line feed for some serial drivers Alison Wang
2016-02-25 3:00 ` Bin Meng
2016-02-25 3:02 ` Huan Wang
2016-02-25 3:17 ` Bin Meng
2016-02-25 4:58 ` Huan Wang
2016-02-25 5:46 ` Bin Meng
2016-03-02 2:49 ` Huan Wang
2016-02-25 14:19 ` James Chargin
2016-03-02 4:41 ` Huan Wang
2016-02-25 17:55 ` Marek Vasut [this message]
2016-02-26 1:30 ` Bin Meng
2016-02-26 1:56 ` Simon Glass
2016-02-26 9:45 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CF4017.3040505@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.