From: Taeung Song <treeze.taeung@gmail.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
Jiri Olsa <jolsa@redhat.com>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 3/3] perf script: Remove duplicated code and needless a script_spec__findnew()
Date: Fri, 26 Feb 2016 04:17:56 +0900 [thread overview]
Message-ID: <56CF5364.90509@gmail.com> (raw)
In-Reply-To: <20160225191606.GR8720@kernel.org>
On 02/26/2016 04:16 AM, Arnaldo Carvalho de Melo wrote:
> Em Thu, Feb 25, 2016 at 08:02:22PM +0100, Jiri Olsa escreveu:
>> On Fri, Feb 26, 2016 at 12:13:10AM +0900, Taeung Song wrote:
>>> script_spec_register() called two functions
>>> script_spec__find() and script_spec__findnew().
>>> But script_spec__find() was called two times.
>>>
>>> So remove script_spec__findnew() and make
>>> script_spec_register() only call once script_spec__find().
>>>
>>> Cc: Jiri Olsa <jolsa@kernel.org>
>>> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
>>
>> Acked-by: Jiri Olsa <jolsa@kernel.org>
>
> Looks good, applied.
>
> Thanks,
>
> - Arnaldo
Thank you!!
Taeung
next prev parent reply other threads:[~2016-02-25 19:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 15:13 [PATCH 3/3] perf script: Remove duplicated code and needless a script_spec__findnew() Taeung Song
2016-02-25 19:02 ` Jiri Olsa
2016-02-25 19:06 ` Taeung Song
2016-02-25 19:16 ` Arnaldo Carvalho de Melo
2016-02-25 19:17 ` Taeung Song [this message]
2016-02-27 9:41 ` [tip:perf/core] perf script: Remove duplicated code and needless script_spec__findnew() tip-bot for Taeung Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CF5364.90509@gmail.com \
--to=treeze.taeung@gmail.com \
--cc=arnaldo.melo@gmail.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.