From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tirumalesh Chalamarla Subject: Re: [PATCH V3] AHCI: Workaround for ThunderX Errata#22536 Date: Thu, 25 Feb 2016 12:31:53 -0800 Message-ID: <56CF64B9.4080605@caviumnetworks.com> References: <1455653329-4934-1-git-send-email-tchalamarla@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bn1on0058.outbound.protection.outlook.com ([157.56.110.58]:56347 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751818AbcBYUcB (ORCPT ); Thu, 25 Feb 2016 15:32:01 -0500 In-Reply-To: Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Thomas Gleixner Cc: tj@kernel.org, stripathi@apm.com, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org On 02/17/2016 08:12 AM, Thomas Gleixner wrote: > On Tue, 16 Feb 2016, tchalamarla@caviumnetworks.com wrote: >> +#ifdef CONFIG_ARM64 >> +/* Due to ERRATA#22536, ThunderX need to handle >> + * HOST_IRQ_STAT differently. >> + * Work around is to make sure all pending IRQs >> + * are served before leaving handler >> + */ >> +static irqreturn_t ahci_thunderx_irq_handler(int irq, void *dev_instance) >> +{ >> + struct ata_host *host = dev_instance; >> + struct ahci_host_priv *hpriv; >> + unsigned int rc = 0; >> + void __iomem *mmio; >> + u32 irq_stat, irq_masked; >> + unsigned int handled = 1; >> + >> + VPRINTK("ENTER\n"); > > Come on. This VPRINK stuff is really pointless. Enable irq tracepoints, they > already track the enter/exit of interrupt handlers .... > sure. waiting for some more comments if any. > Thanks, > > tglx > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: tchalamarla@caviumnetworks.com (Tirumalesh Chalamarla) Date: Thu, 25 Feb 2016 12:31:53 -0800 Subject: [PATCH V3] AHCI: Workaround for ThunderX Errata#22536 In-Reply-To: References: <1455653329-4934-1-git-send-email-tchalamarla@caviumnetworks.com> Message-ID: <56CF64B9.4080605@caviumnetworks.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/17/2016 08:12 AM, Thomas Gleixner wrote: > On Tue, 16 Feb 2016, tchalamarla at caviumnetworks.com wrote: >> +#ifdef CONFIG_ARM64 >> +/* Due to ERRATA#22536, ThunderX need to handle >> + * HOST_IRQ_STAT differently. >> + * Work around is to make sure all pending IRQs >> + * are served before leaving handler >> + */ >> +static irqreturn_t ahci_thunderx_irq_handler(int irq, void *dev_instance) >> +{ >> + struct ata_host *host = dev_instance; >> + struct ahci_host_priv *hpriv; >> + unsigned int rc = 0; >> + void __iomem *mmio; >> + u32 irq_stat, irq_masked; >> + unsigned int handled = 1; >> + >> + VPRINTK("ENTER\n"); > > Come on. This VPRINK stuff is really pointless. Enable irq tracepoints, they > already track the enter/exit of interrupt handlers .... > sure. waiting for some more comments if any. > Thanks, > > tglx > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751778AbcBYVFq (ORCPT ); Thu, 25 Feb 2016 16:05:46 -0500 Received: from mail-by2on0086.outbound.protection.outlook.com ([207.46.100.86]:15536 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751726AbcBYVFo (ORCPT ); Thu, 25 Feb 2016 16:05:44 -0500 X-Greylist: delayed 1116 seconds by postgrey-1.27 at vger.kernel.org; Thu, 25 Feb 2016 16:05:44 EST Authentication-Results: lists.infradead.org; dkim=none (message not signed) header.d=none;lists.infradead.org; dmarc=none action=none header.from=caviumnetworks.com; Subject: Re: [PATCH V3] AHCI: Workaround for ThunderX Errata#22536 To: Thomas Gleixner References: <1455653329-4934-1-git-send-email-tchalamarla@caviumnetworks.com> CC: , , , , From: Tirumalesh Chalamarla Message-ID: <56CF64B9.4080605@caviumnetworks.com> Date: Thu, 25 Feb 2016 12:31:53 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.2.3.194] X-ClientProxiedBy: CO2PR18CA0031.namprd18.prod.outlook.com (25.161.80.41) To BLUPR0701MB1780.namprd07.prod.outlook.com (25.162.87.150) X-Microsoft-Exchange-Diagnostics: 1;BLUPR0701MB1780;2:vkLXk9KDo2KIdbgvwoA9ScyQFDGY9ls47xmrN2S4b8D4HbVuW7A99cdNJ+xLN4hboe26ZYIxjHsD7Jy3pT9OALE2zhw610SPO9XerXKL8lcIOyJaDStXT4cAkn1Hn+cpZla618b7uX8AXDjKJNRrSQ==;3:zRz1UJWbLroVu4Q5T9wiNO480hGzIgiGgyRxAzZAKRxprDmehMggW6ibkN2E/tXD8MYea0jyP6muxEugW4B8MYDtPwFBwhau2UtbAr17bz88i4q5wvwwRp1swioU+IY9;25:BnS4N9BcAVNOjEFG545mdOrdK04zCAKk4zP1gOojwTXZ7NrLOQ4IyJC1v6lYDzoBe6Fk7wKfAqfQNCYSYY4chXB1+h2s8euQVLbcY8Y9g253dlR4WpjAGmtFJwqt1KO0XdmlMf49kQU3oEAej18ak9kKOgtx6/ZdaB0FyRgvgybZgTUU8O2Ym26RLV+rqrypole7Pt5ZoexlhVPRKiXirriaq/E2dWc60WPqyxUKtbI88sHNWlGgNQ+Y9mih5s/clDQIZj83O8qeauVb6uvdjpcA1zUS8HUBCDKy9q0r2vEzOLqHYLiFxr+qfm1TlOtjOW2g6BaMp0Xrvg/AE11RGA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1780; X-MS-Office365-Filtering-Correlation-Id: 6f68746f-dadb-444c-7e6e-08d33e22b586 X-Microsoft-Exchange-Diagnostics: 1;BLUPR0701MB1780;20:CVmvfpaqN3N3N2CxbM+5mlgf+jrosupgAS+nXQ49dgtVt6nT7ZO4pWtGsMKoeA37HVy+hAG2elIpkOdXwzrWE3s+4gcUnM1Ynfu/lQWHLCXVAcmrwNQ1OJLqd97Hacv798NLNbFlg9fOb3LtT24Oavyw2Uf28H8r67YwTp/OB7SJT1uDEMIJotxI9PQ4v+d3mYw+IMF9PeiennbrBYkqVNpjkflCTTpU6VBN1mAuQwdIKg/SynGTKdXXlxiI2vQKx4+5+XwyeK2utYWG1zlUARBJK+nxBZIZ0hDMfWJMUg+Ub0+YIAtV1ZDSqupIPGhUFH0GHleqI3XoOVxYj/fIZWiMBH5CotY7d0l0+i2NtPJbHeeGdzmS6/0ceKqpnuiviZsb4fUrqhg41hgMm4Wr7g4FAK+gDvMoq1BcQLXg8cSpOhF8k2VMBJsHz2lvQfYPHf1Yvi+ttYjFfirbo0er7NJ7tjNa0byb0eGumH3VFdBlYKf0ne3i9i0pwDFtF/ROcllYjtgXFxpqZ+RRKxrw3XTh8ghY9EWmwFy+VwJRCtqtqzKIcgWfqkzIvbDNZlecOUnEgcueR0XLJ5zgYIwfy7h05vz7gTpDQpq0X/BaCFI= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:BLUPR0701MB1780;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1780; X-Microsoft-Exchange-Diagnostics: 1;BLUPR0701MB1780;4:/ce+WVDnUUOHoNGRXgjzARpzScLz9eyyXDSnM1i74RGuftIwGneTvaVIIeSOIV/YmAN7Gn3FSSVYV53PlwbdIfmqFQqDR3UCwMYRVrTbwK6/w0ag/Df2xAz9pHakesN+b9zttYBO6ty67Iyx2/C4+3e1aQGV7iwpRtmE9LsVCPyGrXdup0js77wXYFCV1ABa7ZtkHtiKb4g9UuULqSGxN/SB8fmRVGurSgVuUNAkH/gxcWyv0CkNB+sxLLL0s7UO6RY0xIGu1CILmlBlaR713BuHjLPXSt5geE5cTQ1YhXCj1hF9UluwXWef+rcnvVI8IMkt99dSi8JBZ2TyHXh11/5WKcpagyYdVMSrd/pRzYip0lNfsgXjYF/Q+gfCnR2s X-Forefront-PRVS: 08635C03D4 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(479174004)(377454003)(24454002)(164054003)(54356999)(50986999)(76176999)(65816999)(77096005)(87266999)(19580405001)(80316001)(19580395003)(2950100001)(42186005)(83506001)(87976001)(33656002)(23746002)(40100003)(36756003)(2906002)(586003)(6116002)(1096002)(3846002)(64126003)(65806001)(4326007)(5008740100001)(5001960100002)(50466002)(122386002)(189998001)(4001350100001)(92566002)(47776003)(66066001)(5004730100002)(110136002)(230700001);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR0701MB1780;H:[10.18.104.43];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BLUPR0701MB1780;23:ZF8iDmx6RY9V7ZVeJ8JpVnEntNPnG0rXQ9J?= =?Windows-1252?Q?zLvS3DWGBSGJjJc0Yeo3magFbBVWa8XF/n/8IDwybIzA0x1OseWSMrdd?= =?Windows-1252?Q?kjPhpHTzpGRRSHqX1QawmfAUJAl3X8k61pQ9dh3pHDVncd4bW3hu/CPX?= =?Windows-1252?Q?dKKKINPp4ohAe/70fF7tRNnFG+mlGGxPFr6nwDJEi/JIzSLGtJ3MioEs?= =?Windows-1252?Q?DCB2fo3zRfWk9hdPTaxZZr4zxAInSs+bH4clEfKg5ZNbsnHFtJbznTq/?= =?Windows-1252?Q?10XiBKGOeEz6CNtv3Aua3mpPC4pHzMTngpjroym18ZBeFQGdhb7lQt8e?= =?Windows-1252?Q?UBHpdxtKbvPwh5Q8uiNDDWerqEGvNthkIszpu1b01PO66XyLtpfAeqGU?= =?Windows-1252?Q?bWNJiQE3ppFV8sxL5vANJIS57ypmTn+VDP8IwfCI0fw+EvGngbvEQe/D?= =?Windows-1252?Q?Nx7gVVbqBZiVOXwJYqXne8SHI7c2MhVTY+VwSt27NE4Rai19pmtgKKm9?= =?Windows-1252?Q?s4mcXwZhpf+wJqzVOiqeWpb4itx5o7Ezj1apgJtpV4ZhSue6yChiRe9x?= =?Windows-1252?Q?VsoVpCq3cHW2vlx0kVwSg9O/75J6pK8CU3WiKo/5oR1z6OGXgAuc42JY?= =?Windows-1252?Q?7I9RkgSMiylntNCX80Wt/yopLylJlyR4QIfhpMP5icivkCf8lj867hjq?= =?Windows-1252?Q?nVoUSiOj/wqlMOdpXWicvANNpwnAw+OiSGd2VbzeqF2QDiJ7h7VicDWb?= =?Windows-1252?Q?fBRCrZXJU/4djIiOz8AwjBxSAYHaBQhXHqK+HZRvf/CEAZnDLCFYFtr5?= =?Windows-1252?Q?oKO3d1Ixg2XoLfbkBSbJXKOrKpaRRkCzSCC3awEQOZzMO2vvjcfyZFw3?= =?Windows-1252?Q?6KX01uA6/u5VxUJqTsC+ceJjJEbd2LdwxbygBsSOttuQNNNF9sUiPqAZ?= =?Windows-1252?Q?M45sRXfV0v+hLDLVpnd7EKyJj7iBksyJXJ+rMfohCsbeJXCL3ZazIgOt?= =?Windows-1252?Q?UGgdWRcQV8lbuzxy3qJGm9lIDQIHKB93HYGtHnQOzaF4icy3W3MKorJ+?= =?Windows-1252?Q?zHDjGjUq0lLytiw6HlqNJD/fkfvJ/GnE4wo3IYucu+t+brYgpsCpANs9?= =?Windows-1252?Q?Yh6pjfFsCP26Y0VcfZqPZzVe5FydEsu0u3ufAFxuk2tjP6c2d49Hnx8J?= =?Windows-1252?Q?qTu06UufDsnt0OfwkWyxReCaIUKt8ImWX7ZMjngzAD5G/xc+2LDNGXqS?= =?Windows-1252?Q?JxD38SEGYEaMu6IRmag=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR0701MB1780;5:LBvMlmznj5Eygu3P5jsw4KzurDsOnbLOAclcDsu8ZY+KD59k5EJBo+tpOGIrbkKqkM54cUO9714xW9WFTWwj7bdT3o92lSgL3HNSYNgiDWSTAs1hIIzRHcQqaCnGdmGntw8ykG6YP6mYnVdqaG9t1w==;24:MIpuXxhnIT8/xqSdURJttHkud2WQfPZAl5EV/b5HLJS/05uIBAt/XDIvnLswxdzC45z8NmEJIQEQG+n5fN7VDip9xUMKQkOc7apOoxTZIc0= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2016 20:31:57.6547 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1780 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/17/2016 08:12 AM, Thomas Gleixner wrote: > On Tue, 16 Feb 2016, tchalamarla@caviumnetworks.com wrote: >> +#ifdef CONFIG_ARM64 >> +/* Due to ERRATA#22536, ThunderX need to handle >> + * HOST_IRQ_STAT differently. >> + * Work around is to make sure all pending IRQs >> + * are served before leaving handler >> + */ >> +static irqreturn_t ahci_thunderx_irq_handler(int irq, void *dev_instance) >> +{ >> + struct ata_host *host = dev_instance; >> + struct ahci_host_priv *hpriv; >> + unsigned int rc = 0; >> + void __iomem *mmio; >> + u32 irq_stat, irq_masked; >> + unsigned int handled = 1; >> + >> + VPRINTK("ENTER\n"); > > Come on. This VPRINK stuff is really pointless. Enable irq tracepoints, they > already track the enter/exit of interrupt handlers .... > sure. waiting for some more comments if any. > Thanks, > > tglx > >