All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Ehmanns <universeii@gmx.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Add config to nfsd to set number of threads
Date: Thu, 25 Feb 2016 21:40:50 +0100	[thread overview]
Message-ID: <56CF66D2.2080804@gmx.de> (raw)
In-Reply-To: <56BDA67E.8060404@gmx.de>

Yann,
is the patch o.k. for you? Shall I resend it using git?
Please let me know.

Regards,
Andreas

Am 12.02.2016 um 10:31 schrieb Andreas Ehmanns:
> Yann,
> indeed a killall -9 worked. So I reworked the patch. According to 
> Thomas' recommendation I added the OK/FAIL output as done in the 
> dropbox init script.
> Please have a look at the attached patch. If it's o.k., I'll resend it 
> using git.
>
> Regards,
> Andreas
>
> Am 04.02.2016 um 21:50 schrieb Yann E. MORIN:
>> Andreas, All,
>>
>> On 2016-02-04 09:31 +0100, Andreas Ehmanns spake thusly:
>>> Dear Yann,
>>> please find below the rework of the nfsd init script.
>>> The changes are very small. Please note that a change from
>>>
>>> kill -9 `pidof nfsd` 2>/dev/null
>>>
>>> to killall was not possible since killall did not kill the nfsd 
>>> threads. It
>>> simply did not work and I couldn't figure out the root cause.
>> What about using something like;
>>      rpc.nfsd 0
>>      killall -9 nfsd
>>
>>  From 'man rpc.nfsd':
>>      In particular rpc.nfsd 0 will stop all threads and thus close any
>>      open connections.
>>
>> (maybe with a little sleep in-between the two calls to let things settle
>> down?)
>>
>> Care to have a look, please?
>>
>>> Let me know what you think about. If it's o.k. for you, I re-send 
>>> the patch
>>> using git.
>> Well, it's already a nice improvement. ;-)
>>
>> Please, consider the above suggestion. Adapt the script if required, and
>> respin with git, please.
>>
>> Thanks! :-)
>>
>> Regards,
>> Yann E. MORIN.
>>
>>>  From 13fa8728220cfe80b7ab3d48837183088f4094d5 Mon Sep 17 00:00:00 2001
>>> From: Andreas Ehmanns <universeII@gmx.de>
>>> Date: Thu, 4 Feb 2016 09:23:35 +0100
>>> Subject: [PATCH 1/1] Reordered kill, echo and pid file remove
>>>
>>> Signed-off-by: Andreas Ehmanns <universeII@gmx.de>
>>> ---
>>>   package/nfs-utils/S60nfs | 7 ++++---
>>>   1 file changed, 4 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/package/nfs-utils/S60nfs b/package/nfs-utils/S60nfs
>>> index 5639b8f..0bd5a44 100755
>>> --- a/package/nfs-utils/S60nfs
>>> +++ b/package/nfs-utils/S60nfs
>>> @@ -38,8 +38,8 @@ start() {
>>>         printf "Starting NFS mountd: "
>>>       rpc.mountd
>>> -    echo "done"
>>>       touch /var/lock/subsys/nfs
>>> +    echo "done"
>>>   }
>>>     stop() {
>>> @@ -54,14 +54,15 @@ stop() {
>>>         printf "Shutting down NFS services: "
>>>       /usr/sbin/exportfs -au
>>> -    rm -f /var/lock/subsys/nfs
>>>       killall -q rpc.statd
>>> +    rm -f /var/lock/subsys/nfs
>>>       echo "done"
>>>         printf "Stopping NFS statd: "
>>>       killall -q rpc.statd
>>> -    echo "done"
>>> +    rm -f /var/run/rpc.statd.pid
>>>       rm -f /var/lock/subsys/nfslock
>>> +    echo "done"
>>>   }
>>>     # See how we were called.
>>> -- 
>>> 2.1.4
>>>
>>
>
>
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160225/00c2e837/attachment.html>

  reply	other threads:[~2016-02-25 20:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-17 19:45 [Buildroot] [PATCH 1/1] Add config to nfsd to set number of threads Andreas Ehmanns
2015-12-17 20:04 ` Yann E. MORIN
2015-12-17 20:14   ` Andreas Ehmanns
2015-12-17 20:25     ` Yann E. MORIN
2015-12-17 20:26       ` Andreas Ehmanns
2016-02-04  8:31       ` Andreas Ehmanns
2016-02-04 20:50         ` Yann E. MORIN
2016-02-12  9:31           ` Andreas Ehmanns
2016-02-25 20:40             ` Andreas Ehmanns [this message]
2016-02-25 23:30               ` Arnout Vandecappelle
2016-04-15  8:37                 ` Andreas Ehmanns
2016-04-15  9:00                   ` Arnout Vandecappelle
2016-04-15  9:09                     ` Andreas Ehmanns
2016-04-15  9:23                       ` Arnout Vandecappelle
2015-12-17 20:52 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CF66D2.2080804@gmx.de \
    --to=universeii@gmx.de \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.