All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ruei, Eric" <a0850410@ti.com>
To: "Stiffler, Jacob" <j-stiffler@ti.com>,
	"Ruei, Eric" <e-ruei1@ti.com>,
	"meta-arago@arago-project.org" <meta-arago@arago-project.org>
Subject: Re: [PATCH V2] tisdk Makefile: Replace PVR_NULLDRM with TARGET_PRODUCT per graphics DDK change
Date: Thu, 25 Feb 2016 18:01:42 -0500	[thread overview]
Message-ID: <56CF87D6.8040906@ti.com> (raw)
In-Reply-To: <4B26FB5A64EBA14C87266869E037F9581423B553@DFLE09.ent.ti.com>

On 2/25/2016 5:57 PM, Stiffler, Jacob wrote:
>
>
>> -----Original Message-----
>> From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
>> bounces@arago-project.org] On Behalf Of Ruei, Eric
>> Sent: Thursday, February 25, 2016 5:54 PM
>> To: meta-arago@arago-project.org
>> Subject: [meta-arago] [PATCH V2] tisdk Makefile: Replace PVR_NULLDRM
>> with TARGET_PRODUCT per graphics DDK change
>>
>> PVR_NULLDRM is only applicable for DDK 1.9 and is no longer used.
>> TARGET_PRODUCT is required for omapdrm-pvr build per DDK 1.14
>>
>> Signed-off-by: Eric Ruei <e-ruei1@ti.com>
>> ---
>>   .../recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb     | 9 ++++-----
>>   1 file changed, 4 insertions(+), 5 deletions(-)
>>
>> diff --git a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-
>> makefile_1.0.bb b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-
>> tisdk-makefile_1.0.bb
>> index bcd78ba..ccfd734 100644
>> --- a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-
>> makefile_1.0.bb
>> +++ b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-
>> makefile_1.0.bb
>> @@ -156,10 +156,9 @@ PLATFORM_OMAPDRM_ti33x = "omap335x"
>>   PLATFORM_OMAPDRM_ti43x = "omap437x"
>>   PLATFORM_OMAPDRM_omap-a15 = "omap5430"
>>
>
> What about PLATFORM_OMAPDRM? Use for this was also removed with the change to the makefile fragment.
>
>  From commit (346c53c5e38d02b1901936bfb7388db55e3e30ec):
>
> -       make -C ./eurasia_km/eurasiacon/build/linux2/__PLATFORM_OMAPDRM___linux ARCH=arm KERNELDIR=$(LINUXKERNEL_INSTALL_DIR) PVR_NULLDRM=__PVR_NULLDRM__
> +       make -C ./eurasia_km/eurasiacon/build/linux2/omap_linux ARCH=arm TARGET_PRODUCT=__TARGET_PRODUCT__ KERNELDIR=$(LINUXKERNEL_INSTALL_DIR)
>
>

You are right. It should be removed, too.

Eric


>> -PVR_NULLDRM = ""
>> -PVR_NULLDRM_ti33x = "1"
>> -PVR_NULLDRM_ti43x = "0"
>> -PVR_NULLDRM_omap-a15 = "0"
>> +TARGET_PRODUCT = "jacinto6evm"
>> +TARGET_PRODUCT_ti33x = "ti335x"
>> +TARGET_PRODUCT_ti43x = "ti437x"
>>
>>   PLATFORM_DEBUGSS = ""
>>   PLATFORM_DEBUGSS_dra7xx = "DRA7xx_PLATFORM"
>> @@ -239,7 +238,7 @@ do_install () {
>>       sed -i -e "s/__SDKMACHINE__/${SDKMACHINE}/g" ${D}/Makefile
>>
>>       sed -i -e "s/__PLATFORM_OMAPDRM__/${PLATFORM_OMAPDRM}/"
>> ${D}/Makefile
>> -    sed -i -e "s/__PVR_NULLDRM__/${PVR_NULLDRM}/" ${D}/Makefile
>> +    sed -i -e "s/__TARGET_PRODUCT__/${TARGET_PRODUCT}/" ${D}/Makefile
>>       sed -i -e "s/__PLATFORM_DEBUGSS__/${PLATFORM_DEBUGSS}/g"
>> ${D}/Makefile
>>       sed -i -e
>> "s/__PLATFORM_GDBSERVERPROXY__/${PLATFORM_GDBSERVERPROXY}/g"
>> ${D}/Makefile
>>       sed -i -e
>> "s/__BOOT_MONITOR_MAKE_TARGET__/${BOOT_MONITOR_MAKE_TARGET}
>> /g" ${D}/Makefile
>> --
>> 1.9.1
>>
>> _______________________________________________
>> meta-arago mailing list
>> meta-arago@arago-project.org
>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago



      reply	other threads:[~2016-02-25 23:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-25 22:53 [PATCH V2] tisdk Makefile: Replace PVR_NULLDRM with TARGET_PRODUCT per graphics DDK change Eric Ruei
2016-02-25 22:57 ` Stiffler, Jacob
2016-02-25 23:01   ` Ruei, Eric [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CF87D6.8040906@ti.com \
    --to=a0850410@ti.com \
    --cc=e-ruei1@ti.com \
    --cc=j-stiffler@ti.com \
    --cc=meta-arago@arago-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.