From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jindal, Sonika" Subject: Re: [4.4-rc1][Regression] drm/i915: Check live status before reading edid Date: Fri, 26 Feb 2016 11:38:54 +0530 Message-ID: <56CFEBF6.8060409@intel.com> References: <56CE22DB.6050108@canonical.com> <000C66961D35964B9714611E548C10AD0C3FF620@BGSMSX104.gar.corp.intel.com> <56CF4AE8.6020706@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <56CF4AE8.6020706@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Joseph Salisbury Cc: Daniel Vetter , intel-gfx , LKML , "oleksandr@natalenko.name" , dri-devel , "Vivi, Rodrigo" List-Id: dri-devel@lists.freedesktop.org CgpPbiAyLzI2LzIwMTYgMTI6MTEgQU0sIEpvc2VwaCBTYWxpc2J1cnkgd3JvdGU6Cj4gT24gMDIv MjQvMjAxNiAxMDo1MyBQTSwgSmluZGFsLCBTb25pa2Egd3JvdGU6Cj4+IEhpIEpvZSwKPj4KPj4g WWVzLCBmaXJzdCB0aGluZyB0byB0cnkgaXMgdG8gaW5jcmVhc2UgdGhlIHRyaWVzLgo+IFdlIHRl c3Rpbmcgd2l0aCAzMDAgcmV0cmllcywgYnV0IHRoZSBzZWNvbmQgbW9uaXRvciBzdGlsbCBkaWQg bm90IHNob3cKPiB1cC4gIEhvd2V2ZXIsIGl0IGRpZCBzaG93IHVwIGluIGxzcGNpLgo+Cj4KPj4g Q2FuIHlvdSBwbGVhc2UgcG9pbnQgbWUgdG8gdGhlIGJ1ZyBhbmQgcHJvdmlkZSBtb3JlIGRldGFp bHMgbGlrZSBwbGF0Zm9ybSwgbW9uaXRvciwgY2FibGUuCj4gVGhlIGJ1ZyBpcyBhdDogaHR0cDov L3BhZC5sdi8xNTQzNjgzIC4gIEFsbCB0aGUgaGFyZHdhcmUgZGV0YWlscyBzaG91bGQKPiBiZSBp biB0aGUgYnVnIHJlcG9ydC4gIFRoZSBjYWJsZSBpcyBhIHNpbmdsZSBsaW5rIGR2aS1kIGNhYmxl Lgo+IFVuZm9ydHVuYXRlbHkgdGhlIGJ1ZyByZXBvcnRlciBkb2VzIG5vdCBoYXZlIGEgZHVhbCBs aW5rIGNhYmxlIHRvIHRlc3QuCj4gSWYgeW91IG5lZWQgYW55IGFkZGl0aW9uYWwgaW5mbywgd2Ug Y2FuIGFzayB0aGUgYnVnIHJlcG9ydGVyLgpJZiB0aGlzIGlzIHdpdGggc2luZ2xlIGxpbmsgY2Fi bGUsIHRoZSBpc3N1ZSBjb3VsZCBiZSB0aGUgc2FtZS4KQXMgVmlsbGUgc3VnZ2VzdGVkIGZvciB0 aGUgb3RoZXIgaXNzdWUgdG8gdXNlIHZpZGVvPUhETUktQS0xOmUgYXMgCmNvbW1hbmQgbGluZSBh cmd1bWVudCwgY2FuIHlvdSBwbGVhc2UgZ2l2ZSBpdCBhIHRyeT8KVGhlIGxvZ3Mgc2hhcmVkIGlu IHRoZSBidWcgZG9lc24ndCBoYXZlIGRybSBsb2dzIGVuYWJsZWQsIHNvIGNvdWxkbnQgZ2V0IApt dWNoIG91dCBvZiBpdC4KV2hpY2ggcGxhdGZvcm0gaXMgdGhpcz8KCkFsdGVybmF0aXZlbHkgeW91 IGNhbiBhZGQgc29tZXRoaW5nIGxpa2UgZm9sbG93aW5nIGluIGludGVsX2hkbWlfZGV0ZWN0IAp0 byBtYWtlIGl0IGlnbm9yZSB0aGUgbGl2ZSBzdGF0dXMgY2hlY2tzLgoKQEAgLTE0MTksNyArMTQx OSw3IEBAIGludGVsX2hkbWlfZGV0ZWN0KHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3Is IApib29sIGZvcmNlKQoKICAgICAgICAgaW50ZWxfaGRtaV91bnNldF9lZGlkKGNvbm5lY3Rvcik7 Ci0KKyAgICAgICBsaXZlX3N0YXR1cyA9IGxpdmVfc3RhdHVzIHwgZm9yY2U7CiAgICAgICAgIGlm IChpbnRlbF9oZG1pX3NldF9lZGlkKGNvbm5lY3RvciwgbGl2ZV9zdGF0dXMpKSB7CiAgICAgICAg ICAgICAgICAgc3RydWN0IGludGVsX2hkbWkgKmludGVsX2hkbWkgPSAKaW50ZWxfYXR0YWNoZWRf aGRtaShjb25uZWN0b3IpOwoKClJlZ2FyZHMsClNvbmlrYQo+PiBBcmUgeW91IHJlZmVycmluZyB0 byB0aGUgc2FtZSBpc3N1ZSBhcyBPbGVrc2FuZHIgcmVwb3J0ZWQgd2hlcmUgYSBzaW5nbGUgbGlu ayBkdmkvaGRtaSBjYWJsZSBkaWRu4oCZdCB3b3JrIGFuZCBkdWFsIGxpbmsgd29ya2VkPwo+IEkn bSBub3Qgc3VyZSBpZiB0aGlzIGlzIHRoZSBleGFjdCBpc3N1ZSBvciBub3QuICBJJ2xsIHJldmll dyB0aGUgb3RoZXIKPiB0aHJlYWQgYW5kIGNvbXBhcmUuCj4KPj4gUmVnYXJkcywKPj4gU29uaWth Cj4+Cj4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4+IEZyb206IEpvc2VwaCBTYWxpc2J1 cnkgW21haWx0bzpqb3NlcGguc2FsaXNidXJ5QGNhbm9uaWNhbC5jb21dCj4+IFNlbnQ6IFRodXJz ZGF5LCBGZWJydWFyeSAyNSwgMjAxNiAzOjA5IEFNCj4+IFRvOiBKaW5kYWwsIFNvbmlrYSA8c29u aWthLmppbmRhbEBpbnRlbC5jb20+Cj4+IENjOiBTaGFybWEsIFNoYXNoYW5rIDxzaGFzaGFuay5z aGFybWFAaW50ZWwuY29tPjsgVml2aSwgUm9kcmlnbyA8cm9kcmlnby52aXZpQGludGVsLmNvbT47 IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+OyBKYW5pIE5pa3VsYSA8amFu aS5uaWt1bGFAbGludXguaW50ZWwuY29tPjsgRGF2aWQgQWlybGllIDxhaXJsaWVkQGxpbnV4Lmll PjsgaW50ZWwtZ2Z4IDxpbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnPjsgZHJpLWRldmVs IDxkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnPjsgTEtNTCA8bGludXgta2VybmVsQHZn ZXIua2VybmVsLm9yZz4KPj4gU3ViamVjdDogWzQuNC1yYzFdW1JlZ3Jlc3Npb25dIGRybS9pOTE1 OiBDaGVjayBsaXZlIHN0YXR1cyBiZWZvcmUgcmVhZGluZyBlZGlkCj4+Cj4+IEhpIFNvbmlrYSwK Pj4KPj4gQSBrZXJuZWwgYnVnIHJlcG9ydCB3YXMgb3BlbmVkIGFnYWluc3QgVWJ1bnR1IFswXS4g IEFmdGVyIGEga2VybmVsIGJpc2VjdCwgaXQgd2FzIGZvdW5kIHRoYXQgcmV2ZXJ0aW5nIHRoZSBm b2xsb3dpbmcgY29tbWl0IHJlc29sdmVkIHRoaXMgYnVnOgo+Pgo+PiBjb21taXQgMjM3ZWQ4NmM2 OTNkOGE4ZTRkYjQ3Njk3NmFlYjMwZGY0ZGVhYzc0Ygo+PiBBdXRob3I6IFNvbmlrYSBKaW5kYWwg PHNvbmlrYS5qaW5kYWxAaW50ZWwuY29tPgo+PiBEYXRlOiAgIFR1ZSBTZXAgMTUgMDk6NDQ6MjAg MjAxNSArMDUzMAo+Pgo+PiAgICAgIGRybS9pOTE1OiBDaGVjayBsaXZlIHN0YXR1cyBiZWZvcmUg cmVhZGluZyBlZGlkCj4+Cj4+Cj4+Cj4+IFRoZSByZWdyZXNzaW9uIHdhcyBpbnRyb2R1Y2VkIGFz IG9mIHY0LjQtcmMxLgo+Pgo+PiBJIHdhcyBob3BpbmcgdG8gZ2V0IHlvdXIgZmVlZGJhY2ssIHNp bmNlIHlvdSBhcmUgdGhlIHBhdGNoIGF1dGhvci4gIERvIHRoaW5rIGluY3JlYXNpbmcgdGhlIG51 bWJlciBvZiB0cmllcyBpbiBpbnRlbF9oZG1pX2RldGVjdCgpIGlzIHdvcnRoIHRyeWluZz8gIERv IHlvdSB0aGluayBnYXRoZXJpbmcgYW55IGFkZGl0aW9uYWwgZGF0YSB3aWxsIGhlbHAgZGlhZ25v c2UgdGhpcyBpc3N1ZSwgb3Igd291bGQgaXQgYmUgYmVzdCB0byBzdWJtaXQgYSByZXZlcnQgcmVx dWVzdD8KPj4gICAgICAKPj4KPj4gVGhhbmtzLAo+PiAgICAgIAo+PiBKb2UKPj4KPj4gWzBdIGh0 dHA6Ly9wYWQubHYvbHAxNTQzNjgzCj4+Cj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753355AbcBZGJA (ORCPT ); Fri, 26 Feb 2016 01:09:00 -0500 Received: from mga04.intel.com ([192.55.52.120]:53376 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750829AbcBZGI7 (ORCPT ); Fri, 26 Feb 2016 01:08:59 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,498,1449561600"; d="scan'208";a="659555898" Subject: Re: [4.4-rc1][Regression] drm/i915: Check live status before reading edid To: Joseph Salisbury References: <56CE22DB.6050108@canonical.com> <000C66961D35964B9714611E548C10AD0C3FF620@BGSMSX104.gar.corp.intel.com> <56CF4AE8.6020706@canonical.com> Cc: "Sharma, Shashank" , "Vivi, Rodrigo" , Daniel Vetter , Jani Nikula , David Airlie , intel-gfx , dri-devel , LKML , "oleksandr@natalenko.name" , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= From: "Jindal, Sonika" Message-ID: <56CFEBF6.8060409@intel.com> Date: Fri, 26 Feb 2016 11:38:54 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56CF4AE8.6020706@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/26/2016 12:11 AM, Joseph Salisbury wrote: > On 02/24/2016 10:53 PM, Jindal, Sonika wrote: >> Hi Joe, >> >> Yes, first thing to try is to increase the tries. > We testing with 300 retries, but the second monitor still did not show > up. However, it did show up in lspci. > > >> Can you please point me to the bug and provide more details like platform, monitor, cable. > The bug is at: http://pad.lv/1543683 . All the hardware details should > be in the bug report. The cable is a single link dvi-d cable. > Unfortunately the bug reporter does not have a dual link cable to test. > If you need any additional info, we can ask the bug reporter. If this is with single link cable, the issue could be the same. As Ville suggested for the other issue to use video=HDMI-A-1:e as command line argument, can you please give it a try? The logs shared in the bug doesn't have drm logs enabled, so couldnt get much out of it. Which platform is this? Alternatively you can add something like following in intel_hdmi_detect to make it ignore the live status checks. @@ -1419,7 +1419,7 @@ intel_hdmi_detect(struct drm_connector *connector, bool force) intel_hdmi_unset_edid(connector); - + live_status = live_status | force; if (intel_hdmi_set_edid(connector, live_status)) { struct intel_hdmi *intel_hdmi = intel_attached_hdmi(connector); Regards, Sonika >> Are you referring to the same issue as Oleksandr reported where a single link dvi/hdmi cable didn’t work and dual link worked? > I'm not sure if this is the exact issue or not. I'll review the other > thread and compare. > >> Regards, >> Sonika >> >> -----Original Message----- >> From: Joseph Salisbury [mailto:joseph.salisbury@canonical.com] >> Sent: Thursday, February 25, 2016 3:09 AM >> To: Jindal, Sonika >> Cc: Sharma, Shashank ; Vivi, Rodrigo ; Daniel Vetter ; Jani Nikula ; David Airlie ; intel-gfx ; dri-devel ; LKML >> Subject: [4.4-rc1][Regression] drm/i915: Check live status before reading edid >> >> Hi Sonika, >> >> A kernel bug report was opened against Ubuntu [0]. After a kernel bisect, it was found that reverting the following commit resolved this bug: >> >> commit 237ed86c693d8a8e4db476976aeb30df4deac74b >> Author: Sonika Jindal >> Date: Tue Sep 15 09:44:20 2015 +0530 >> >> drm/i915: Check live status before reading edid >> >> >> >> The regression was introduced as of v4.4-rc1. >> >> I was hoping to get your feedback, since you are the patch author. Do think increasing the number of tries in intel_hdmi_detect() is worth trying? Do you think gathering any additional data will help diagnose this issue, or would it be best to submit a revert request? >> >> >> Thanks, >> >> Joe >> >> [0] http://pad.lv/lp1543683 >> >