From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38176) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZEOL-0005KJ-C4 for qemu-devel@nongnu.org; Fri, 26 Feb 2016 04:08:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZEOE-0002vO-IH for qemu-devel@nongnu.org; Fri, 26 Feb 2016 04:08:53 -0500 Received: from mx2.parallels.com ([199.115.105.18]:51043) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZEOE-0002sd-4i for qemu-devel@nongnu.org; Fri, 26 Feb 2016 04:08:46 -0500 Message-ID: <56D0160E.6020805@virtuozzo.com> Date: Fri, 26 Feb 2016 12:08:30 +0300 From: Vladimir Sementsov-Ogievskiy MIME-Version: 1.0 References: <1456343639-3471-1-git-send-email-mst@redhat.com> <1456343639-3471-6-git-send-email-mst@redhat.com> <56CEA6BE.60504@virtuozzo.com> <20160225102409-mutt-send-email-mst@redhat.com> <56CEC19C.4020400@virtuozzo.com> <20160225110947-mutt-send-email-mst@redhat.com> <56CECF63.5060002@virtuozzo.com> <56CED2CC.3040208@redhat.com> In-Reply-To: <56CED2CC.3040208@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 05/23] pc-dimm: add pc_dimm_build_list() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , "Michael S. Tsirkin" Cc: Peter Maydell , qemu-devel@nongnu.org, Igor Mammedov On 25.02.2016 13:09, Paolo Bonzini wrote: > > On 25/02/2016 10:54, Vladimir Sementsov-Ogievskiy wrote: >> On 25.02.2016 12:11, Michael S. Tsirkin wrote: >>> On Thu, Feb 25, 2016 at 11:55:56AM +0300, Vladimir Sementsov-Ogievskiy >>> wrote: >>>> On 25.02.2016 11:39, Michael S. Tsirkin wrote: >>>>> On Thu, Feb 25, 2016 at 10:01:18AM +0300, Vladimir >>>>> Sementsov-Ogievskiy wrote: >>>>>> Stop! >>>>> It builds fine here. Did you check out my tree? >>>> anyway, this file should be here, as it is added into Makefile: >>>> >>>> --- a/stubs/Makefile.objs >>>> +++ b/stubs/Makefile.objs >>>> @@ -35,7 +35,7 @@ stub-obj-y += vmstate.o >>>> stub-obj-$(CONFIG_WIN32) += fd-register.o >>>> stub-obj-y += cpus.o >>>> stub-obj-y += kvm.o >>>> -stub-obj-y += qmp_pc_dimm_device_list.o >>>> +stub-obj-y += pc_dimm.o >>>> stub-obj-y += target-monitor-defs.o >>>> stub-obj-y += target-get-monitor-def.o >>>> stub-obj-y += vhost.o >>>> >>> Hmm that's right. >>> Thanks! >>> Looks like it was picking up an old object in the filesystem :( >>> I'll respin - for now, does everything work for you if you drop >>> this line from the makefile? >> it will break compilation for targets without memory hotplug, it was >> discussed on list. stubs are necessary. > mst, > > indeed it's not clear to me why you're deleting qmp_pc_dimm_device_list.c... to put pc_dimm related stubs (qmp_pc_dimm_device_list, pc_dimm_build_list) into one file - stubs/pc_dimm.c > > On the other hand, pc_dimm_build_list doesn't need a stub. Just put it > in hw/virtio/virtio-balloon.c. It's up to you ofcourse, but for me it is strange. Logically, pc_dimm_build_list is related to pc_dimm.c, and, also there is very similar function pc_dimm_build_list_sorted - it is in pc_dimm.c too (may be these two function should be merged somehow in future). > > Paolo > >>>> =========== >>>> git clone git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tmp >>>> cd tmp/ >>>> git checkout for_upstream >>>> ./configure --target-list=x86_64-softmmu >>>> make -j9 >>>>> make: *** No rule to make target `stubs/pc_dimm.o', needed by >>>> `libqemustub.a'. Stop >> -- Best regards, Vladimir