From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 30/33] drm/omap: verify that fb plane pitches are the same Date: Fri, 26 Feb 2016 11:12:21 +0200 Message-ID: <56D016F5.4060903@ti.com> References: <1455875288-4370-1-git-send-email-tomi.valkeinen@ti.com> <1711537.Yp97coqSLh@avalon> <56CF2449.1060908@ti.com> <2125324.iAn21aN6Ny@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0759058967==" Return-path: Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [192.94.94.40]) by gabe.freedesktop.org (Postfix) with ESMTPS id B344B6EA47 for ; Fri, 26 Feb 2016 09:12:26 +0000 (UTC) In-Reply-To: <2125324.iAn21aN6Ny@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0759058967== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0U0g6hTpf8UA6dcIGMDJMr99RwPanmm7N" --0U0g6hTpf8UA6dcIGMDJMr99RwPanmm7N Content-Type: multipart/mixed; boundary="NRp4eO0x4Rg5LJ6cIQrXTi5GUoCPABamw" From: Tomi Valkeinen To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, Rob Clark Message-ID: <56D016F5.4060903@ti.com> Subject: Re: [PATCH 30/33] drm/omap: verify that fb plane pitches are the same References: <1455875288-4370-1-git-send-email-tomi.valkeinen@ti.com> <1711537.Yp97coqSLh@avalon> <56CF2449.1060908@ti.com> <2125324.iAn21aN6Ny@avalon> In-Reply-To: <2125324.iAn21aN6Ny@avalon> --NRp4eO0x4Rg5LJ6cIQrXTi5GUoCPABamw Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 26/02/16 10:55, Laurent Pinchart wrote: >> I don't quite understand what you mean. The checks apply to all planes= =2E >=20 > My point is that if you add a check to ensure that the pitch is identic= al in=20 > all planes, the other tests on the pitch don't have to be repeated for = every=20 > plane. Hmm... The other tests also depend on the plane's bpp, so I'm not sure if any of those can be skipped. But I agree, the loop with the checks does look somewhat complex, and there's probably room for improvement. Tomi --NRp4eO0x4Rg5LJ6cIQrXTi5GUoCPABamw-- --0U0g6hTpf8UA6dcIGMDJMr99RwPanmm7N Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJW0Bb1AAoJEPo9qoy8lh71Nx4P/3OMcHyViTSNtjgizbmXr9UY YC1kZkFWu89QpMzWcn7B1aauyGu0rFMc08VSFtKCHmz23wPIP750OH0eVb2aHkTT GMXo21tQGWxnXXiGJzB3V2svNeoN/yorlHj+VE5jVXdVqvrbsx2AzjG0FMpvQftI 1NazbDawOYaYAmljyJyGQFlheIyyRfsnsKjHKPZGo390wQgQpQoWovwf366Hc7rf 6IRJn4xjwHulqns8d2oenonb5vvxz6kx/+yz+0IIfosxwcZ40Dm5nagTvWDh2+OG jwtDY/iHFW3ANZIYPvP+9I/XANma+XYtiYqIzgfWMXywbjaCDP+xogNFAFXijORN g9jVfbJ/tN6khphvZBYHKq0onD2AoQiV/mxCmguvIgPiOm+zM+cpikEcnXGzVUMy A01r7aLF2erRiTyp+nDqfJ1sVxHaUJT0djztcGL5j3mQqXebeD7OiZSUPv1a4BbE Mv+uDxraAF3fyXUpGNLGZgeArY6Hd34egL0Q6oc3s5BR5hlkWMBOZrKWQh87XZLt afzmWJpg768M/98i6N6MWAkbLxZWYGvFYqRepdBz7kQhA/lxfGIBoFdw8VfajZR5 /pCrxcp4q5V2sgWR6B7PHlpdE05HVYAn9KOwAXvX7miNei2/vREZ/3blKUmxxCOP +R7tUfI9VrMmCdBSLUX5 =Xd+9 -----END PGP SIGNATURE----- --0U0g6hTpf8UA6dcIGMDJMr99RwPanmm7N-- --===============0759058967== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0759058967==--