Re: [PATCH] xen: add hypercall option to temporarily pin a vcpu

[Juergen Gross <jgross@suse.com>]

On 26/02/16 12:20, Dario Faggioli wrote:
> On Fri, 2016-02-26 at 12:14 +0100, Juergen Gross wrote:
>> On 26/02/16 11:39, Jan Beulich wrote:
>>>> @@ -679,6 +691,8 @@ int cpu_disable_scheduler(unsigned int cpu)
>>>>                      v->affinity_broken = 1;
>>>>                  }
>>>>  
>>>> +                printk(XENLOG_DEBUG "Breaking affinity for
>>>> %pv\n", v);
>>> Wouldn't it be even better to make this the "else" to the
>>> preceding if(), since in the suspend case this is otherwise going
>>> to be printed for every vCPU not currently running on pCPU0?
>> Yes, I'll change it.
>>
> On this, can (either of) you elaborate a bit more? I don't think I'm
> following...

In the suspend case the affinity will be broken only temporarily, so
there is no need to print the debug message.


juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel