Re: [PATCH v2] arm/monitor vm-events: Implement guest-request support

[Razvan Cojocaru <rcojocaru@bitdefender.com>]

On 02/26/2016 01:07 PM, Corneliu ZUZU wrote:
> This patch adds ARM support for guest-request monitor vm-events.
> Note: on ARM hypercall instruction skipping must be done manually
> by the caller. This will probably be changed in a future patch.
> 
> Summary of changes:
> == Moved to common-side:
>   * XEN_DOMCTL_MONITOR_EVENT_GUEST_REQUEST handling (moved from X86
>       arch_monitor_domctl_event to common monitor_domctl)
>   * hvm_event_guest_request->vm_event_monitor_guest_request
>   * hvm_event_traps->vm_event_monitor_traps (also added target vcpu as param)
>   * guest-request bits from X86 'struct arch_domain' (to common 'struct domain')
> == ARM implementations:
>   * do_hvm_op now handling of HVMOP_guest_request_vm_event => calls
>       vm_event_monitor_guest_request (as on X86)
>   * arch_monitor_get_capabilities->vm_event_monitor_get_capabilities,
>     updated to reflect support for XEN_DOMCTL_MONITOR_EVENT_GUEST_REQUEST
>   * vm_event_init_domain (does nothing), vm_event_cleanup_domain
> == Misc:
>   * vm_event_fill_regs, no longer X86-specific. ARM-side implementation of this
>       function currently does nothing, that will be added in a separate patch.
> 
> Signed-off-by: Corneliu ZUZU <czuzu@bitdefender.com>
> ---
> Changed since v1:
>   * hvm_event_traps, hvm_event_guest_request moved to common/vm_event.c and
>       and renamed to vm_event_monitor_traps and vm_event_monitor_guest_request
>   * arch_monitor_get_capabilities moved to vm_event.h and renamed to
>       vm_event_monitor_get_capabilities
>   * arch_hvm_event_fill_regs replaced w/ existing vm_event_fill_regs
>       (see commit adc75eba8b15c7103a010f736fe62e3fb2383964)
>   * defined altp2m_active for ARM and altp2m_vcpu_idx to remove #ifdef in
>       vm_event_monitor_traps
>   * change bitfield members type to unsigned int
> ---
>  xen/arch/arm/hvm.c              |  8 ++++
>  xen/arch/x86/hvm/event.c        | 82 ++++++++---------------------------------
>  xen/arch/x86/hvm/hvm.c          |  3 +-
>  xen/arch/x86/monitor.c          | 18 +--------
>  xen/arch/x86/vm_event.c         |  1 +
>  xen/common/monitor.c            | 36 +++++++++++++++---
>  xen/common/vm_event.c           | 60 ++++++++++++++++++++++++++++++
>  xen/include/asm-arm/altp2m.h    | 39 ++++++++++++++++++++
>  xen/include/asm-arm/monitor.h   |  8 +---
>  xen/include/asm-arm/vm_event.h  | 19 +++++++++-
>  xen/include/asm-x86/altp2m.h    | 10 +++--
>  xen/include/asm-x86/domain.h    |  4 +-
>  xen/include/asm-x86/hvm/event.h | 13 +++++--
>  xen/include/asm-x86/monitor.h   | 23 ------------
>  xen/include/asm-x86/vm_event.h  | 23 ++++++++++++
>  xen/include/xen/sched.h         |  6 +++
>  xen/include/xen/vm_event.h      |  9 +++++
>  17 files changed, 232 insertions(+), 130 deletions(-)
>  create mode 100644 xen/include/asm-arm/altp2m.h

Acked-by: Razvan Cojocaru <rcojocaru@bitdefender.com>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel