All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pranit Bauva <pranit.bauva@zoho.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] SubmittingPatches : WIP tag in patches
Date: Fri, 26 Feb 2016 14:19:21 +0000	[thread overview]
Message-ID: <56D05EE9.8020400@zoho.com> (raw)
In-Reply-To: <CAPig+cT9Aqm0+AEGz0F-CTihMJtMw45fq4h6zxKs_7uxHak0bg@mail.gmail.com>

Eric Sunshine:
> On Fri, Feb 26, 2016 at 9:05 AM, Pranit Bauva <pranit.bauva@zoho.com> wrote:
>> ---
> 
> Missing sign-off.
> 

I have to inoculate the habit of signing off every time.
>> diff --git a/Documentation/SubmittingPatches
>> @@ -168,7 +168,9 @@ the closing bracket to mark the nature of the patch
>> is also
>>  encouraged.  E.g. [PATCH/RFC] is often used when the patch is
>>  not ready to be applied but it is for discussion, [PATCH v2],
>>  [PATCH v3] etc. are often seen when you are sending an update to
>> -what you have previously sent.
>> +what you have previously sent. [PATCH/WIP] is often used when some
> 
> Perhaps: /is often/can be/
> 
>> +work is yet left to be done on the patch but you want to get the
>> +review on the completed part of the patch.
> 
> Maybe: s/review/feedback/
> 
>>  "git format-patch" command follows the best current practice to
>>  format the body of an e-mail message.  At the beginning of the
>> --
>> 2.1.4

I have done the required changes, now I should send another email with
tag [PATCH v2] right?

  reply	other threads:[~2016-02-26  8:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-26 14:05 [PATCH] SubmittingPatches : WIP tag in patches Pranit Bauva
2016-02-26  8:00 ` Eric Sunshine
2016-02-26 14:19   ` Pranit Bauva [this message]
2016-02-26  8:19     ` Stefan Tatschner
2016-02-26  8:19     ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D05EE9.8020400@zoho.com \
    --to=pranit.bauva@zoho.com \
    --cc=git@vger.kernel.org \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.