From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55691) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZKmT-0007tl-6w for qemu-devel@nongnu.org; Fri, 26 Feb 2016 10:58:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZKmP-0006dg-Pf for qemu-devel@nongnu.org; Fri, 26 Feb 2016 10:58:13 -0500 References: <1456417362-20652-1-git-send-email-bharata@linux.vnet.ibm.com> <1456417362-20652-6-git-send-email-bharata@linux.vnet.ibm.com> From: Eric Blake Message-ID: <56D0760D.1000702@redhat.com> Date: Fri, 26 Feb 2016 08:58:05 -0700 MIME-Version: 1.0 In-Reply-To: <1456417362-20652-6-git-send-email-bharata@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vr3WiDVM11ifIodTpWnTWEX0UlIcmJ2AM" Subject: Re: [Qemu-devel] [RFC PATCH v0 5/6] qmp, spapr: Show hot-plugged/pluggable CPU slots in the Machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao , qemu-devel@nongnu.org Cc: mjrosato@linux.vnet.ibm.com, thuth@redhat.com, pkrempa@redhat.com, ehabkost@redhat.com, aik@ozlabs.ru, armbru@redhat.com, agraf@suse.de, borntraeger@de.ibm.com, qemu-ppc@nongnu.org, pbonzini@redhat.com, imammedo@redhat.com, mdroth@linux.vnet.ibm.com, afaerber@suse.de, david@gibson.dropbear.id.au This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vr3WiDVM11ifIodTpWnTWEX0UlIcmJ2AM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/25/2016 09:22 AM, Bharata B Rao wrote: > Implement query cpu-slots that provides information about hot-plugged > as well as hot-pluggable CPU slots that the machine supports. >=20 > TODO: As Eric suggested use enum for type instead of str. > TODO: @hotplug-granularity probably isn't required. I guess this is still marked TODO because the series is still RFC? >=20 > Signed-off-by: Bharata B Rao > --- > +++ b/qapi-schema.json > @@ -4083,3 +4083,88 @@ > ## > { 'enum': 'ReplayMode', > 'data': [ 'none', 'record', 'play' ] } > + > +## > +# @CPUInfo: > +# > +# Information about CPUs > +# > +# @arch-id: Arch-specific ID for the CPU. > +# > +# @type: QOM type of the CPU. > +# > +# @thread: Thread ID of the CPU. > +# > +# @core: Core ID of the CPU. > +# > +# @socket: Socket ID of the CPU. > +# > +# @node: NUMA node to which the CPU belongs. Please add the '#optional' tag to the fields which are not always present= =2E > +# > +# @qom-path: QOM path of the CPU object > +# > +# Since: 2.6 > +## > + > +{ 'struct': 'CPUInfo', > + 'data': { 'arch-id': 'int', > + 'type': 'str', The TODO in the commit message mentions that this should be converted to an enum. > + '*thread': 'int', > + '*core': 'int', > + '*socket' : 'int', > + '*node' : 'int', > + '*qom-path': 'str' > + } But looking better than the previous round. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --vr3WiDVM11ifIodTpWnTWEX0UlIcmJ2AM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW0HYNAAoJEKeha0olJ0Nq6XMH/RQcpzpHwJHZTNuGOPLAfPEn N+WLSPZ0itPlDfmJhGu2whJyizJH7MnNHxpXMrsEvt8eQPW4NLTSH7++wrk+7DPM MDLCWcNbr1++X3fhb62YysFoS+kaMoNqye6YOLfth5JMYhH+tu/kJ3ALtcL/qY8B AbnrkEpSoBCThQSB8iazv3zRnLPsLEj3d3in3sKoUVl1Od/A7I6eTSQkqvZ6St8j osih98cXuUL6RQ6SlZcDZUUK/UQV1w+uMCFGCN+IA1WwWGUpn237kJAVVO/BB71H k+QB8Z9sOgADtkBcCwRjQkcaaubUgypKfHDBO+ddZ4VclF8ZNJNdHQREqMfOXko= =QtNN -----END PGP SIGNATURE----- --vr3WiDVM11ifIodTpWnTWEX0UlIcmJ2AM--