From mboxrd@z Thu Jan 1 00:00:00 1970 From: f.fainelli@gmail.com (Florian Fainelli) Date: Fri, 26 Feb 2016 10:36:27 -0800 Subject: [PATCH] bsp: add SoC device to brcmstb In-Reply-To: <4679582.DyKPu0pJrQ@wuerfel> References: <1456445947-9079-1-git-send-email-justinpopo6@gmail.com> <4679582.DyKPu0pJrQ@wuerfel> Message-ID: <56D09B2B.8090805@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 26/02/16 05:58, Arnd Bergmann wrote: > On Thursday 25 February 2016 16:19:07 Justin Chen wrote: >> */ >> void brcmstb_biuctrl_init(void); >> >> +/* >> + * Helper functions for getting family or product id from the >> + * SoC driver. >> + */ >> +u32 brcmstb_get_family_id(void); >> +u32 brcmstb_get_product_id(void); >> + >> #endif /* __BRCMSTB_SOC_H */ >> -- > > Please remove the declarations from the header file and make the > variable local to this file, to make sure no other driver accidentally > accesses them. I would remove these two helper functions completely, we do not need them right now in an upstream kernel, if we ever need them, we could add them back, but we have no use for these two now. Thanks! -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933805AbcBZShu (ORCPT ); Fri, 26 Feb 2016 13:37:50 -0500 Received: from mail-pa0-f41.google.com ([209.85.220.41]:36336 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754585AbcBZShs (ORCPT ); Fri, 26 Feb 2016 13:37:48 -0500 Subject: Re: [PATCH] bsp: add SoC device to brcmstb To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org References: <1456445947-9079-1-git-send-email-justinpopo6@gmail.com> <4679582.DyKPu0pJrQ@wuerfel> Cc: Justin Chen , linux-kernel@vger.kernel.org, f.fainelli@gmail.com, sbranden@broadcom.com, rjui@broadcom.com, Justin Chen , bcm-kernel-feedback-list@broadcom.com, gregory.0xf0@gmail.com, computersforpeace@gmail.com From: Florian Fainelli Message-ID: <56D09B2B.8090805@gmail.com> Date: Fri, 26 Feb 2016 10:36:27 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <4679582.DyKPu0pJrQ@wuerfel> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/02/16 05:58, Arnd Bergmann wrote: > On Thursday 25 February 2016 16:19:07 Justin Chen wrote: >> */ >> void brcmstb_biuctrl_init(void); >> >> +/* >> + * Helper functions for getting family or product id from the >> + * SoC driver. >> + */ >> +u32 brcmstb_get_family_id(void); >> +u32 brcmstb_get_product_id(void); >> + >> #endif /* __BRCMSTB_SOC_H */ >> -- > > Please remove the declarations from the header file and make the > variable local to this file, to make sure no other driver accidentally > accesses them. I would remove these two helper functions completely, we do not need them right now in an upstream kernel, if we ever need them, we could add them back, but we have no use for these two now. Thanks! -- Florian