From: Dave Hansen <dave.hansen@linux.intel.com>
To: Colin King <colin.king@canonical.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
"H . Peter Anvin" <hpa@linux.intel.com>,
x86@kernel.org, Borislav Petkov <bp@alien8.de>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/mpx: Fix off-by-one comparison with nr_registers
Date: Fri, 26 Feb 2016 11:08:12 -0800 [thread overview]
Message-ID: <56D0A29C.9040504@linux.intel.com> (raw)
In-Reply-To: <1456512931-3388-1-git-send-email-colin.king@canonical.com>
On 02/26/2016 10:55 AM, Colin King wrote:
> In the unlikely event that regno == nr_registers then we get an array
> overrun on regoff because the invalid register check is currently
> off-by-one. Fix this with a check that regno is >= nr_registers instead.
>
> Detected with static analysis using CoverityScan.
Oh, the irony of an overrun in the MPX code! Thanks for catching this.
Acked-by: Dave Hansen <dave.hansen@intel.com>
next prev parent reply other threads:[~2016-02-26 19:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 18:55 [PATCH] x86/mpx: Fix off-by-one comparison with nr_registers Colin King
2016-02-26 19:08 ` Dave Hansen [this message]
2016-02-26 21:15 ` [tip:x86/urgent] " tip-bot for Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D0A29C.9040504@linux.intel.com \
--to=dave.hansen@linux.intel.com \
--cc=bp@alien8.de \
--cc=colin.king@canonical.com \
--cc=hpa@linux.intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.