From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422889AbcBZTLg (ORCPT ); Fri, 26 Feb 2016 14:11:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40759 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754589AbcBZTLf (ORCPT ); Fri, 26 Feb 2016 14:11:35 -0500 Subject: Re: [PATCH v3] kernel: sched: fix preempt_disable_ip recodring for preempt_disable() To: Sebastian Andrzej Siewior , Steven Rostedt References: <1455290420-23831-1-git-send-email-bigeasy@linutronix.de> <20160225091530.4dc3481c@gandalf.local.home> <20160226135456.GB18244@linutronix.de> Cc: Ingo Molnar , Peter Zijlstra , linux-kernel@vger.kernel.org From: Daniel Bristot de Oliveira Message-ID: <56D0A364.5060203@redhat.com> Date: Fri, 26 Feb 2016 16:11:32 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160226135456.GB18244@linutronix.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/26/2016 10:54 AM, Sebastian Andrzej Siewior wrote: > - trace_preempt_off(CALLER_ADDR0, get_parent_ip(CALLER_ADDR1)); > + trace_preempt_off(CALLER_ADDR0, get_lock_parent_ip()); If !lock_functions(CALLER_ADDR0), the start/stop_critical_timing() will be called with parent_ip == ip. Hence, the following trace on start_critical_timing(): __trace_function(tr, ip, parent_ip, flags, preempt_count()); Will show the function calling itself. Is it a problem? am I missing something? -- Daniel