From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38705) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZOxb-0004Pj-E0 for qemu-devel@nongnu.org; Fri, 26 Feb 2016 15:26:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZOxV-0008W3-W0 for qemu-devel@nongnu.org; Fri, 26 Feb 2016 15:25:59 -0500 Received: from mail-qg0-x241.google.com ([2607:f8b0:400d:c04::241]:35386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZOxV-0008Vr-RH for qemu-devel@nongnu.org; Fri, 26 Feb 2016 15:25:53 -0500 Received: by mail-qg0-x241.google.com with SMTP id p68so1637599qge.2 for ; Fri, 26 Feb 2016 12:25:53 -0800 (PST) Sender: Richard Henderson References: <1456156787-17509-1-git-send-email-alex.bennee@linaro.org> <1456156787-17509-6-git-send-email-alex.bennee@linaro.org> From: Richard Henderson Message-ID: <56D0B4CE.3060204@twiddle.net> Date: Fri, 26 Feb 2016 12:25:50 -0800 MIME-Version: 1.0 In-Reply-To: <1456156787-17509-6-git-send-email-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v7 5/9] qemu-log: new option -dfilter to limit output List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, crosthwaitepeter@gmail.com, dgilbert@redhat.com, aurelien@aurel32.net On 02/22/2016 07:59 AM, Alex Bennée wrote: > + qemu_set_dfilter_ranges("0x1000+0x100"); > + > + g_assert_false(qemu_log_in_addr_range(0xfff)); > + g_assert(qemu_log_in_addr_range(0x1000)); > + g_assert(qemu_log_in_addr_range(0x1100)); This is exactly what I was talking about wrt off-by-one error in my first review -- 0x100 bytes, including 0x1000, finishes at 0x10ff. This third test should fail. r~