All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: John Garry <john.garry@huawei.com>,
	JBottomley@odin.com, martin.petersen@oracle.com
Cc: linuxarm@huawei.com, john.garry2@mail.dcu.ie,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/6] hisi_sas: add hisi_sas_slave_configure()
Date: Sat, 27 Feb 2016 19:59:56 +0800	[thread overview]
Message-ID: <56D18FBC.8050501@suse.de> (raw)
In-Reply-To: <1456393335-38294-6-git-send-email-john.garry@huawei.com>

On 02/25/2016 05:42 PM, John Garry wrote:
> In high-datarate aging tests, it is found that the
> SCSI framework can periodically issue lu resets as
> some commands timeout.
> Response TASK SET FULL and SAS_QUEUE_FULL may be
> returned many times for the same command, causing the
> timeouts.
> The SAS_QUEUE_FULL errors come from
> TRANS_TX_CREDIT_TIMEOUT_ERR, TRANS_TX_CLOSE_NORMAL_ERR,
> and TRANS_TX_ERR_FRAME_TXED errors. They do not mean
> that the queue is full in the host, but rather it is
> equivalent to meaning the queue is full for the sdev.
> To overcome this, the queue depth for the sdev is
> reduced to 64 (from 256, set in sas_slave_configure()).
> Normally error code SAS_QUEUE_FULL will result in the
> sdev queue depth falling, but it falls too slowly during
> high-datarate tests and commands timeout before it
> has fallen to an adequete level from original value.
> 
> Signed-off-by: John Garry <john.garry@huawei.com>
> ---
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Hannes Reinecke <hare@suse.de>
To: John Garry <john.garry@huawei.com>,
	JBottomley@odin.com, martin.petersen@oracle.com
Cc: linuxarm@huawei.com, john.garry2@mail.dcu.ie,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/6] hisi_sas: add hisi_sas_slave_configure()
Date: Sat, 27 Feb 2016 19:59:56 +0800	[thread overview]
Message-ID: <56D18FBC.8050501@suse.de> (raw)
In-Reply-To: <1456393335-38294-6-git-send-email-john.garry@huawei.com>

On 02/25/2016 05:42 PM, John Garry wrote:
> In high-datarate aging tests, it is found that the
> SCSI framework can periodically issue lu resets as
> some commands timeout.
> Response TASK SET FULL and SAS_QUEUE_FULL may be
> returned many times for the same command, causing the
> timeouts.
> The SAS_QUEUE_FULL errors come from
> TRANS_TX_CREDIT_TIMEOUT_ERR, TRANS_TX_CLOSE_NORMAL_ERR,
> and TRANS_TX_ERR_FRAME_TXED errors. They do not mean
> that the queue is full in the host, but rather it is
> equivalent to meaning the queue is full for the sdev.
> To overcome this, the queue depth for the sdev is
> reduced to 64 (from 256, set in sas_slave_configure()).
> Normally error code SAS_QUEUE_FULL will result in the
> sdev queue depth falling, but it falls too slowly during
> high-datarate tests and commands timeout before it
> has fallen to an adequete level from original value.
> 
> Signed-off-by: John Garry <john.garry@huawei.com>
> ---
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)

  reply	other threads:[~2016-02-27 12:00 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-25  9:42 [PATCH v2 0/6] hisi_sas: add abort and retry feature John Garry
2016-02-25  9:42 ` John Garry
2016-02-25  9:42 ` [PATCH v2 1/6] hisi_sas: change tmf func complete check John Garry
2016-02-25  9:42   ` John Garry
2016-02-27 11:56   ` Hannes Reinecke
2016-02-25  9:42 ` [PATCH v2 2/6] hisi_sas: add hisi_sas_slot_abort() John Garry
2016-02-25  9:42   ` John Garry
2016-02-27 11:57   ` Hannes Reinecke
2016-02-25  9:42 ` [PATCH v2 3/6] hisi_sas: use slot abort in v1 hw John Garry
2016-02-25  9:42   ` John Garry
2016-02-27 11:58   ` Hannes Reinecke
2016-02-25  9:42 ` [PATCH v2 4/6] hisi_sas: use slot abort in v2 hw John Garry
2016-02-25  9:42   ` John Garry
2016-02-27 11:59   ` Hannes Reinecke
2016-02-25  9:42 ` [PATCH v2 5/6] hisi_sas: add hisi_sas_slave_configure() John Garry
2016-02-25  9:42   ` John Garry
2016-02-27 11:59   ` Hannes Reinecke [this message]
2016-02-27 11:59     ` Hannes Reinecke
2016-02-25  9:42 ` [PATCH v2 6/6] hisi_sas: update driver version to 1.3 John Garry
2016-02-25  9:42   ` John Garry
2016-02-27 12:00   ` Hannes Reinecke
2016-03-01  2:00 ` [PATCH v2 0/6] hisi_sas: add abort and retry feature Martin K. Petersen
2016-03-01  2:00   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D18FBC.8050501@suse.de \
    --to=hare@suse.de \
    --cc=JBottomley@odin.com \
    --cc=john.garry2@mail.dcu.ie \
    --cc=john.garry@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.