All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Lawrence <joe.lawrence@stratus.com>
To: Atsushi Kumagai <ats-kumagai@wm.jp.nec.com>,
	"anderson@redhat.com" <anderson@redhat.com>
Cc: "kexec@lists.infradead.org" <kexec@lists.infradead.org>,
	Laurence Oberman <loberman@redhat.com>,
	"Discussion list for crash utility usage,
	 maintenance and development" <crash-utility@redhat.com>
Subject: Re: [Crash-utility] makedumpfile: 4.5 kernel commit breaks page filtering
Date: Sat, 27 Feb 2016 09:03:52 -0500	[thread overview]
Message-ID: <56D1ACC8.3000400@stratus.com> (raw)
In-Reply-To: <0910DD04CBD6DE4193FCF86B9C00BE9701E24FD4@BPXM01GP.gisp.nec.co.jp>

On 02/25/2016 07:35 PM, Atsushi Kumagai wrote:
> Hello Dave,
>
>>> Note that PAGE_MAPPING_ANON is now only set in the compound_head page,
>>> so when makedumpfile walks though the pages, it will have to look
>>> at each page's head page for the bit setting.
>>
>> Thanks for your report.
>> As you said, it seems checking the head page like kernel does is necessary.
>> I'll try to work it out, please give me some time.
>
> Reading head page's page->mapping for each tail page will take extra time,
> so I contrived another way.
>
> It's just skipping compound tail pages for filtering.
> If makedumpfile excludes compound pages, it will be done at a time by
> exclude_range() at the time of checking the compound head page. We don't
> need to check compound tail pages individually.
>
> I made the patch, could you test the *compound* branch below ?
> This version requires a new unexported symbol, you need to specify
> -x vmlinux for now.
>
>    https://sourceforge.net/p/makedumpfile/code/ci/compound/tree/

Hi Atsushi, Dave,

Running the makedumpfile compound branch on 4.5-rc5 and this kdump.conf 
setting:

core_collector makedumpfile -l --message-level 1 -d 31 -x 
/kdumproot/var/crash/vmlinux

I was able to collect and successfully read a few test dumps without 
incident.  This was inside a VM without any interesting system load, but 
was regularly giving me issues before the patch.

Regards,

-- Joe

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2016-02-27 14:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <349750156.30030224.1455814657685.JavaMail.zimbra@redhat.com>
2016-02-18 17:05 ` makedumpfile: 4.5 kernel commit breaks page filtering Dave Anderson
2016-02-18 17:40   ` Laurence Oberman
2016-02-18 19:24     ` Dave Anderson
2016-02-18 22:11     ` Joe Lawrence
2016-02-22  4:18   ` Atsushi Kumagai
2016-02-26  0:35     ` [Crash-utility] " Atsushi Kumagai
2016-02-27 14:03       ` Joe Lawrence [this message]
2016-02-29  5:56         ` Atsushi Kumagai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D1ACC8.3000400@stratus.com \
    --to=joe.lawrence@stratus.com \
    --cc=anderson@redhat.com \
    --cc=ats-kumagai@wm.jp.nec.com \
    --cc=crash-utility@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=loberman@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.