From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@baker-net.org.uk (Adam Baker) Date: Sat, 27 Feb 2016 20:06:58 +0000 Subject: net: mv643xx: interface does not transmit after some time In-Reply-To: References: <20160206183414.GD17218@lunn.ch> <20160206231935.GA30734@jirafa.cyrius.com> <2ACB3A0B-DD51-43C1-A56E-E7C175645554@schloeter.net> <20160207203545.GB29107@lunn.ch> <312E318A-CAE1-45B1-AB13-EA147B48E315@schloeter.net> <20160210225717.GD14610@lunn.ch> Message-ID: <56D201E2.4060504@baker-net.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/02/16 14:38, Ezequiel Garcia wrote: > (let's expand the Cc a bit) > > On 10 February 2016 at 19:57, Andrew Lunn wrote: >> On Wed, Feb 10, 2016 at 07:40:54PM +0100, Thomas Schl?ter wrote: >>> >>>> Am 08.02.2016 um 19:49 schrieb Thomas Schl?ter : >>>> >>>> >>>>> Am 07.02.2016 um 22:07 schrieb Thomas Schl?ter : >>>>> >>>>> Am 07.02.2016 um 21:35 schrieb Andrew Lunn : >>>>>> >>>>>>>> FWIW, we had a similar bug report in Debian recently: >>>>>>>> https://lists.debian.org/debian-arm/2016/01/msg00098.html >>>>>> >>>>>> Hi Thomas >>>>>> >>>>>> I this thread, Ian Campbell mentions a patch. Please could you try >>>>>> that patch and see if it fixes your problem. >>>>>> >>>>>> Thanks >>>>>> Andrew >>>>> >>>>> Hi Andrew, >>>>> >>>>> I just applied the patch and the NAS is now running it. I???ll try to crash it tonight and keep you informed whether it worked. >>>>> >>>>> Thanks >>>>> Thomas >>>> >>>> Hi Andrew, >>>> >>>> the patch did not fix the problem. After 1.2 GiB RX and 950 MiB TX, the interface crashed again. >>>> >>>> Now I switched off RX/TX offload just to make sure we are talking about the same problem. If we are, the interface should be stable without offload, right? >>>> >>>> Thomas >>> >>> Okay, so I have installed ethtool and switched off all offload features available. Now the NAS is running rock solid for two days. I backed up my Mac using Time Machine / netatalk (450 GiB transferred) and some Linux machines via NFS (100 GiB total) without a problem. >>> >>> How much code is used for mv643xx offload functionality? >>> Is it possible to debug things in the driver and figure out what happens during the crash? >>> Is the hardware offload interface proprietary or reverse engineered or is it a well known API that can be analyzed? >> >> Hi Thomas >> >> Ezequiel Garcia probably knows this part of the driver and hardware >> the best... >> > > The TCP segmentation offload (TSO) implemented in this driver is > mostly a software thing. > > I'm CCing Karl and Philipp, who have fixed subtle issues in the TSO > path, and may be able to help figure this one out. > Hi, Had this issue occur again today. In my case it seems to be triggered by large NFSv4 transfers. I'm running 4.4 plus Nicolas Schichan's patch at https://patchwork.ozlabs.org/patch/573334/ There is a thread a http://forum.doozan.com/read.php?2,17404 suggesting that this has been broken since at least 3.16. I first spotted the issue when upgrading from 3.11 to 4.4. Looking at https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/drivers/net/ethernet/marvell/mv643xx_eth.c I see 2014-05-22 as the date TSO support was first added which is shortly before the merge window opened for 3.16. I'm therefore guessing that TSO has been problematic since it's introduction. Regards Adam From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam Baker Subject: Re: net: mv643xx: interface does not transmit after some time Date: Sat, 27 Feb 2016 20:06:58 +0000 Message-ID: <56D201E2.4060504@baker-net.org.uk> References: <20160206183414.GD17218@lunn.ch> <20160206231935.GA30734@jirafa.cyrius.com> <2ACB3A0B-DD51-43C1-A56E-E7C175645554@schloeter.net> <20160207203545.GB29107@lunn.ch> <312E318A-CAE1-45B1-AB13-EA147B48E315@schloeter.net> <20160210225717.GD14610@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Cc: Thomas Petazzoni , Karl Beldan , netdev@vger.kernel.org, philipp@familie-kirchhofer.de, Martin Michlmayr , Linux ARM Kernel To: Ezequiel Garcia , Andrew Lunn , =?UTF-8?Q?Thomas_Schl=c3=b6ter?= Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: netdev.vger.kernel.org T24gMTEvMDIvMTYgMTQ6MzgsIEV6ZXF1aWVsIEdhcmNpYSB3cm90ZToKPiAobGV0J3MgZXhwYW5k IHRoZSBDYyBhIGJpdCkKPgo+IE9uIDEwIEZlYnJ1YXJ5IDIwMTYgYXQgMTk6NTcsIEFuZHJldyBM dW5uIDxhbmRyZXdAbHVubi5jaD4gd3JvdGU6Cj4+IE9uIFdlZCwgRmViIDEwLCAyMDE2IGF0IDA3 OjQwOjU0UE0gKzAxMDAsIFRob21hcyBTY2hsw7Z0ZXIgd3JvdGU6Cj4+Pgo+Pj4+IEFtIDA4LjAy LjIwMTYgdW0gMTk6NDkgc2NocmllYiBUaG9tYXMgU2NobMO2dGVyIDx0aG9tYXNAc2NobG9ldGVy Lm5ldD46Cj4+Pj4KPj4+Pgo+Pj4+PiBBbSAwNy4wMi4yMDE2IHVtIDIyOjA3IHNjaHJpZWIgVGhv bWFzIFNjaGzDtnRlciA8dGhvbWFzQHNjaGxvZXRlci5uZXQ+Ogo+Pj4+Pgo+Pj4+PiBBbSAwNy4w Mi4yMDE2IHVtIDIxOjM1IHNjaHJpZWIgQW5kcmV3IEx1bm4gPGFuZHJld0BsdW5uLmNoPjoKPj4+ Pj4+Cj4+Pj4+Pj4+IEZXSVcsIHdlIGhhZCBhIHNpbWlsYXIgYnVnIHJlcG9ydCBpbiBEZWJpYW4g cmVjZW50bHk6Cj4+Pj4+Pj4+IGh0dHBzOi8vbGlzdHMuZGViaWFuLm9yZy9kZWJpYW4tYXJtLzIw MTYvMDEvbXNnMDAwOTguaHRtbAo+Pj4+Pj4KPj4+Pj4+IEhpIFRob21hcwo+Pj4+Pj4KPj4+Pj4+ IEkgdGhpcyB0aHJlYWQsIElhbiBDYW1wYmVsbCBtZW50aW9ucyBhIHBhdGNoLiBQbGVhc2UgY291 bGQgeW91IHRyeQo+Pj4+Pj4gdGhhdCBwYXRjaCBhbmQgc2VlIGlmIGl0IGZpeGVzIHlvdXIgcHJv YmxlbS4KPj4+Pj4+Cj4+Pj4+PiBUaGFua3MKPj4+Pj4+ICAgIEFuZHJldwo+Pj4+Pgo+Pj4+PiBI aSBBbmRyZXcsCj4+Pj4+Cj4+Pj4+IEkganVzdCBhcHBsaWVkIHRoZSBwYXRjaCBhbmQgdGhlIE5B UyBpcyBub3cgcnVubmluZyBpdC4gST8/P2xsIHRyeSB0byBjcmFzaCBpdCB0b25pZ2h0IGFuZCBr ZWVwIHlvdSBpbmZvcm1lZCB3aGV0aGVyIGl0IHdvcmtlZC4KPj4+Pj4KPj4+Pj4gVGhhbmtzCj4+ Pj4+ICAgICBUaG9tYXMKPj4+Pgo+Pj4+IEhpIEFuZHJldywKPj4+Pgo+Pj4+IHRoZSBwYXRjaCBk aWQgbm90IGZpeCB0aGUgcHJvYmxlbS4gQWZ0ZXIgMS4yIEdpQiBSWCBhbmQgOTUwIE1pQiBUWCwg dGhlIGludGVyZmFjZSBjcmFzaGVkIGFnYWluLgo+Pj4+Cj4+Pj4gTm93IEkgc3dpdGNoZWQgb2Zm IFJYL1RYIG9mZmxvYWQganVzdCB0byBtYWtlIHN1cmUgd2UgYXJlIHRhbGtpbmcgYWJvdXQgdGhl IHNhbWUgcHJvYmxlbS4gSWYgd2UgYXJlLCB0aGUgaW50ZXJmYWNlIHNob3VsZCBiZSBzdGFibGUg d2l0aG91dCBvZmZsb2FkLCByaWdodD8KPj4+Pgo+Pj4+ICAgICAgVGhvbWFzCj4+Pgo+Pj4gT2th eSwgc28gSSBoYXZlIGluc3RhbGxlZCBldGh0b29sIGFuZCBzd2l0Y2hlZCBvZmYgYWxsIG9mZmxv YWQgZmVhdHVyZXMgYXZhaWxhYmxlLiBOb3cgdGhlIE5BUyBpcyBydW5uaW5nIHJvY2sgc29saWQg Zm9yIHR3byBkYXlzLiBJIGJhY2tlZCB1cCBteSBNYWMgdXNpbmcgVGltZSBNYWNoaW5lIC8gbmV0 YXRhbGsgKDQ1MCBHaUIgdHJhbnNmZXJyZWQpIGFuZCBzb21lIExpbnV4IG1hY2hpbmVzIHZpYSBO RlMgKDEwMCBHaUIgdG90YWwpIHdpdGhvdXQgYSBwcm9ibGVtLgo+Pj4KPj4+IEhvdyBtdWNoIGNv ZGUgaXMgdXNlZCBmb3IgbXY2NDN4eCBvZmZsb2FkIGZ1bmN0aW9uYWxpdHk/Cj4+PiBJcyBpdCBw b3NzaWJsZSB0byBkZWJ1ZyB0aGluZ3MgaW4gdGhlIGRyaXZlciBhbmQgZmlndXJlIG91dCB3aGF0 IGhhcHBlbnMgZHVyaW5nIHRoZSBjcmFzaD8KPj4+IElzIHRoZSBoYXJkd2FyZSBvZmZsb2FkIGlu dGVyZmFjZSBwcm9wcmlldGFyeSBvciByZXZlcnNlIGVuZ2luZWVyZWQgb3IgaXMgaXQgYSB3ZWxs IGtub3duIEFQSSB0aGF0IGNhbiBiZSBhbmFseXplZD8KPj4KPj4gSGkgVGhvbWFzCj4+Cj4+IEV6 ZXF1aWVsIEdhcmNpYSBwcm9iYWJseSBrbm93cyB0aGlzIHBhcnQgb2YgdGhlIGRyaXZlciBhbmQg aGFyZHdhcmUKPj4gdGhlIGJlc3QuLi4KPj4KPgo+IFRoZSBUQ1Agc2VnbWVudGF0aW9uIG9mZmxv YWQgKFRTTykgaW1wbGVtZW50ZWQgaW4gdGhpcyBkcml2ZXIgaXMKPiBtb3N0bHkgYSBzb2Z0d2Fy ZSB0aGluZy4KPgo+IEknbSBDQ2luZyBLYXJsIGFuZCBQaGlsaXBwLCB3aG8gaGF2ZSBmaXhlZCBz dWJ0bGUgaXNzdWVzIGluIHRoZSBUU08KPiBwYXRoLCBhbmQgbWF5IGJlIGFibGUgdG8gaGVscCBm aWd1cmUgdGhpcyBvbmUgb3V0Lgo+CgpIaSwKCkhhZCB0aGlzIGlzc3VlIG9jY3VyIGFnYWluIHRv ZGF5LiBJbiBteSBjYXNlIGl0IHNlZW1zIHRvIGJlIHRyaWdnZXJlZCBieSAKbGFyZ2UgTkZTdjQg dHJhbnNmZXJzLgoKSSdtIHJ1bm5pbmcgNC40IHBsdXMgTmljb2xhcyBTY2hpY2hhbidzIHBhdGNo IGF0Cmh0dHBzOi8vcGF0Y2h3b3JrLm96bGFicy5vcmcvcGF0Y2gvNTczMzM0LwoKVGhlcmUgaXMg YSB0aHJlYWQgYSBodHRwOi8vZm9ydW0uZG9vemFuLmNvbS9yZWFkLnBocD8yLDE3NDA0IHN1Z2dl c3RpbmcgCnRoYXQgdGhpcyBoYXMgYmVlbiBicm9rZW4gc2luY2UgYXQgbGVhc3QgMy4xNi4KCkkg Zmlyc3Qgc3BvdHRlZCB0aGUgaXNzdWUgd2hlbiB1cGdyYWRpbmcgZnJvbSAzLjExIHRvIDQuNC4K Ckxvb2tpbmcgYXQgCmh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvY2dpdC9saW51eC9rZXJuZWwvZ2l0 L3RvcnZhbGRzL2xpbnV4LmdpdC9sb2cvZHJpdmVycy9uZXQvZXRoZXJuZXQvbWFydmVsbC9tdjY0 M3h4X2V0aC5jIApJIHNlZSAyMDE0LTA1LTIyIGFzIHRoZSBkYXRlIFRTTyBzdXBwb3J0IHdhcyBm aXJzdCBhZGRlZCB3aGljaCBpcyAKc2hvcnRseSBiZWZvcmUgdGhlIG1lcmdlIHdpbmRvdyBvcGVu ZWQgZm9yIDMuMTYuIEknbSB0aGVyZWZvcmUgZ3Vlc3NpbmcgCnRoYXQgVFNPIGhhcyBiZWVuIHBy b2JsZW1hdGljIHNpbmNlIGl0J3MgaW50cm9kdWN0aW9uLgoKUmVnYXJkcwoKQWRhbQoKCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg==