From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: staging: libxl compile error in libxl__domain_save Date: Sat, 27 Feb 2016 20:01:48 -0600 Message-ID: <56D2550C.2080605@cardoe.com> References: <20160227081426.GA5356@aepfle.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6557110101782091606==" Return-path: In-Reply-To: <20160227081426.GA5356@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Olaf Hering , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============6557110101782091606== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="KghR6lOKaVrNL5q2goNL7EUWvDRvDqDWN" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --KghR6lOKaVrNL5q2goNL7EUWvDRvDqDWN Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2/27/16 2:14 AM, Olaf Hering wrote: >=20 > Current staging fails to compile: >=20 > [ 276s] libxl_dom_save.c: In function 'libxl__domain_save': > [ 276s] libxl_dom_save.c:328:9: error: 'rc' may be used uninitialized = in this function >=20 > It was introduced between abf8824fe530bcf060c757596f68663c87546a6a and > 3dd926a25d866364ce6d46c21f9ac05a82fa7ffb. Would travis catch such > errors? >=20 Travis currently wouldn't catch this because I've got tools disabled from building. The reason for this is because the configure script fails to properly find Python due to problems with how AC_CHECK_LIB is called. Down the road this doesn't matter because we never use that output from the configure script and instead utilize setuptools to build the extensions which do linking correctly. The relevant patch is here and still waiting for an ACK: http://lists.xen.org/archives/html/xen-devel/2016-02/msg02715.html Once that gets merged and I can enable tools building on Travis then yes it would catch it. --=20 Doug Goldstein --KghR6lOKaVrNL5q2goNL7EUWvDRvDqDWN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJW0lUPXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUqIkP/3l6fspjq0+kEO4aLDjytgWg NE+ZsfzMhrLfYX6JJTcR28noJp1/6eZIwHBYFWi80DuvSrUOBDFmeXCDxyMhch0C j5JDLGZIJBDCSVTYxfR4iNvZSIhWj8o6isaptJuvpPS0WjIdVy0n1352iQYxRQTU cCIZ/qxfsRLWwCTVpaLzJ6DvHnu9FszPg7c1R6pQ5vYd0JCNWnf93rjKrJOYlRm/ owdZGz6zsLJ7hryI8OmcAhFe9wrgc+NVB3BVMz82DppAKivfSGVBqe1VLJYyVFpK UgPHMFqtTJkucQE/EXFeM47loTjhvgZWEz5dT8wuTNUbcEsic21+VK463P/XSBuM XdoFU2waGAhnm4HqcvVm93SQZKkIAJOlnfmUszotH9OZSGzoE1Jd/HTvMAeugeAJ nqiQWw1R05lfuCesQ1oVr1z2lHfcVfc8VhbOYwvkp/srpxQ5RMkLiDyTjaZQd68N Kb4M+xRQI320wpcivWIq3lMZwAFjn9wNSkGmnTi7ElX+8ak0g2L3S1GwehNKhuSM nqNDF6DqsobywwAWcmMEamuGattAonbh6HLFu3YM4YRmQlKxHoqxvwOp9HZhy8Wx Yu5gSx7XlkV271eR1+EVmw2wFNnnSvZi8gJiDINFurZk2Ft86VR44hRa6/kT/kJF K1g2B+p6nhYNHGEVLUKA =dGI4 -----END PGP SIGNATURE----- --KghR6lOKaVrNL5q2goNL7EUWvDRvDqDWN-- --===============6557110101782091606== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============6557110101782091606==--