From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
James Hogan <james.hogan@imgtec.com>,
Ralf Baechle <ralf@linux-mips.org>,
kvm@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH for-4,5] mips/kvm: fix ioctl error handling
Date: Sun, 28 Feb 2016 20:35:54 +0300 [thread overview]
Message-ID: <56D32FFA.1000907@cogentembedded.com> (raw)
In-Reply-To: <1456673711-24132-1-git-send-email-mst@redhat.com>
Hello.
On 02/28/2016 06:35 PM, Michael S. Tsirkin wrote:
> Calling return copy_to_user(...) or return copy_from_user in an ioctl
Calling return? Perhaps "returning the result of"?
> will not do the right thing if there's a pagefault:
> copy_to_user/copy_from_user return the number of bytes not copied in
> this case.
>
> Fix up kvm on mips to do
> return copy_to_user(...)) ? -EFAULT : 0;
> and
> return copy_from_user(...)) ? -EFAULT : 0;
>
> everywhere.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
[...]
MBR, Sergei
next prev parent reply other threads:[~2016-02-28 17:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-28 15:35 [PATCH for-4,5] mips/kvm: fix ioctl error handling Michael S. Tsirkin
2016-02-28 17:35 ` Sergei Shtylyov [this message]
2016-03-02 9:35 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D32FFA.1000907@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=james.hogan@imgtec.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=ralf@linux-mips.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.